Skip to content

Commit 9ea07ad

Browse files
committed
Merge branch 'master' of github.com:krausest/js-framework-benchmark
2 parents fc51cbe + 702f925 commit 9ea07ad

File tree

5 files changed

+100
-94
lines changed

5 files changed

+100
-94
lines changed

.gitignore

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -42,6 +42,7 @@ angular*/app/app.js.map
4242
angular*/src/app.ngsummary.json
4343
tests/results/completed/
4444
target/
45+
webdriver-ts/chrome_profile
4546
webdriver-ts/results/
4647
webdriver-ts/traces/
4748
webdriver-ts/results*/

webdriver-ts-results/src/Common.ts

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -180,7 +180,7 @@ function colorsForStatisticResult(statisticResult: StatisticResult) {
180180
}
181181

182182
const statisticComputeColor = function (sign: number, pValue: number): [string, string, StatisticResult] {
183-
if (pValue > 0.1) {
183+
if (pValue > 0.05) {
184184
return undecided; //['#fff','#000', StatisticResult.Undecided];
185185
}
186186
if (sign <= 0) {
@@ -495,11 +495,14 @@ export class ResultTableData {
495495
const s2_2 = compareWithResultsStdDev * compareWithResultsStdDev;
496496
const n1 = compareWithResultsValues.values.length;
497497
const n2 = resultValues.values.length;
498-
const ny =
499-
Math.pow(s1_2 / n1 + s2_2 / n2, 2) /
500-
((s1_2 * s1_2) / (n1 * n1 * (n1 - 1)) + (s2_2 * s2_2) / (n2 * n2 * (n2 - 1)));
498+
// Welch Welch–Satterthwaite dof
499+
// const dof =
500+
// Math.pow(s1_2 / n1 + s2_2 / n2, 2) /
501+
// ((s1_2 * s1_2) / (n1 * n1 * (n1 - 1)) + (s2_2 * s2_2) / (n2 * n2 * (n2 - 1)));
502+
// simple dof
503+
const dof = n1 + n2 - 2;
501504
const t = (x1 - x2) / Math.sqrt(s1_2 / n1 + s2_2 / n2);
502-
const p = (1.0 - jStat.studentt.cdf(Math.abs(t), ny)) * 2;
505+
const p = (1.0 - jStat.studentt.cdf(Math.abs(t), dof)) * 2;
503506

504507
const statisticalCol = statisticComputeColor(t, p);
505508
const statisticalResult = (p * 100).toFixed(3) + "%";

0 commit comments

Comments
 (0)