refactor(webdriver): remove unused variables

Remove unused variables, imports, function parameters, etc.

Author: nakrovati

webdriver-ts/.eslintrc.cjs

@@ -11,7 +11,6 @@ module.exports = {
   rules: {
     "prefer-const": "off",
     "@typescript-eslint/no-explicit-any": "off",
-    "@typescript-eslint/no-unused-vars": "off",
     "require-await": "error",
     "@typescript-eslint/no-floating-promises": "error",
   },

webdriver-ts/src/benchmarkRunner.ts

@@ -21,7 +21,7 @@ import {
 } from "./benchmarksCommon.js";
 import { StartupBenchmarkResult } from "./benchmarksLighthouse.js";
 import { writeResults } from "./writeResults.js";
-import { PlausibilityCheck, parseCPUTrace } from "./timeline.js";
+import { PlausibilityCheck } from "./timeline.js";
 
 function forkAndCallBenchmark(
   framework: FrameworkData,
@@ -128,6 +128,7 @@ async function runBenchmakLoop(
   framework: FrameworkData,
   benchmarkInfo: CPUBenchmarkInfo | MemBenchmarkInfo,
   benchmarkOptions: BenchmarkOptions,
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
   plausibilityCheck: PlausibilityCheck
 ): Promise<{ errors: string[]; warnings: string[] }> {
   let warnings: string[] = [];

webdriver-ts/src/benchmarksPlaywright.ts

@@ -10,7 +10,7 @@ import {
   cpuBenchmarkInfos,
   memBenchmarkInfos,
 } from "./benchmarksCommon.js";
-import { BenchmarkOptions, config, FrameworkData } from "./common.js";
+import { config, FrameworkData } from "./common.js";
 import {
   checkCountForSelector,
   checkElementContainsText,
@@ -266,7 +266,7 @@ export const benchReadyMemory = new (class extends MemBenchmarkPlaywright {
   async init(browser: Browser, page: Page) {
     await checkElementExists(page, "#run");
   }
-  async run(browser: Browser, page: Page) {
+  async run() {
     return await Promise.resolve(null);
   }
 })();

webdriver-ts/src/benchmarksPuppeteer.ts

@@ -10,7 +10,7 @@ import {
   BenchmarkImpl,
   MemBenchmarkInfo,
 } from "./benchmarksCommon.js";
-import { BenchmarkOptions, config, FrameworkData } from "./common.js";
+import { config, FrameworkData } from "./common.js";
 import {
   checkCountForSelector,
   checkElementContainsText,
@@ -283,7 +283,7 @@ export const benchReadyMemory = new (class extends MemBenchmarkPuppeteer {
   async init(page: Page) {
     await checkElementExists(page, "pierce/#run");
   }
-  async run(page: Page) {
+  async run() {
     return await Promise.resolve(null);
   }
 })();

webdriver-ts/src/benchmarksWebdriverCDP.ts

@@ -5,7 +5,7 @@ import {
   cpuBenchmarkInfos,
   CPUBenchmarkInfo,
 } from "./benchmarksCommon.js";
-import { BenchmarkOptions, config, FrameworkData } from "./common.js";
+import { config, FrameworkData } from "./common.js";
 import {
   clickElementById,
   clickElementByXPath,

webdriver-ts/src/forkedBenchmarkRunnerWebdriverCDP.ts

@@ -151,7 +151,7 @@ async function runCPUBenchmark(
         },
       });
 
-      let p = new Promise((resolve, reject) => {
+      let p = new Promise((resolve) => {
         cdpConnection._wsConnection.on("message", async (msg: any) => {
           let message: any = JSON.parse(msg);
           // console.log("####", typeof message, message.method, Object.keys(message), message);

webdriver-ts/src/isCSPCompliant.ts

@@ -45,7 +45,10 @@ let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
 
 console.log("args.framework", args.framework, !args.framework);
 
-async function runBench(frameworkNames: string[]) {
+async function runBench(
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  frameworkNames: string[] // Not used in the function, but is used when calling the function in other files
+) {
   let runFrameworks;
   let matchesDirectoryArg = (directoryName: string) =>
     allArgs.length == 0 || allArgs.some((arg: string) => arg == directoryName);

webdriver-ts/src/isKeyed.ts

@@ -285,7 +285,10 @@ export async function checkTRcorrect(page: Page): Promise<boolean> {
   return true;
 }
 
-async function runBench(frameworkNames: string[]) {
+async function runBench(
+  // eslint-disable-next-line @typescript-eslint/no-unused-vars
+  frameworkNames: string[] // Not used in the function, but is used when calling the function in other files
+) {
   let runFrameworks;
   let matchesDirectoryArg = (directoryName: string) =>
     frameworkArgument.length == 0 || frameworkArgument.some((arg: string) => arg == directoryName);

webdriver-ts/src/parseTrace.ts

@@ -1,18 +1,6 @@
-import {
-  BenchmarkInfo,
-  BenchmarkType,
-  CPUBenchmarkInfo,
-  cpuBenchmarkInfos,
-  CPUBenchmarkResult,
-} from "./benchmarksCommon.js";
-import { BenchmarkOptions, config, FrameworkData, initializeFrameworks } from "./common.js";
-import {
-  computeResultsCPU,
-  computeResultsJS,
-  parseCPUTrace,
-  PlausibilityCheck,
-} from "./timeline.js";
-import { writeResults } from "./writeResults.js";
+import { cpuBenchmarkInfos } from "./benchmarksCommon.js";
+import { BenchmarkOptions, config, initializeFrameworks } from "./common.js";
+import { computeResultsCPU, parseCPUTrace, PlausibilityCheck } from "./timeline.js";
 
 async function debugSingle() {
   // for (let i = 0; i < 12; i++) {
@@ -29,6 +17,7 @@ async function debugSingle() {
   // }
 }
 
+// eslint-disable-next-line @typescript-eslint/no-unused-vars
 async function debugAll() {
   let benchmarkOptions: BenchmarkOptions = {
     port: 8080,

webdriver-ts/src/timeline.ts

@@ -4,7 +4,6 @@ import * as R from "ramda";
 import { BenchmarkType, CPUBenchmarkInfo, CPUBenchmarkResult } from "./benchmarksCommon.js";
 import { BenchmarkOptions, FrameworkData, Config, config } from "./common.js";
 import { writeResults } from "./writeResults.js";
-import { start } from "repl";
 
 interface TimingResult {
   type: string;
@@ -211,10 +210,7 @@ function logEvents(events: TimingResult[], click: TimingResult) {
   });
 }
 
-export async function computeResultsCPU(
-  fileName: string,
-  warning_logger: (...msg: any) => void = console.log
-): Promise<CPUDurationResult> {
+export async function computeResultsCPU(fileName: string): Promise<CPUDurationResult> {
   const perfLogEvents = await fetchEventsFromPerformanceLog(fileName);
   let events = R.sortBy((e: TimingResult) => e.end)(perfLogEvents);