cleanup and add new lighthouse metrics

Author: krausest

package.json

@@ -8,7 +8,7 @@
     "rebuild-all": "node rebuild-all.js --ci",
     "build": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
     "build-prod": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
-    "compile": "node rebuild-all.js --ci",
+    "compile": "echo \"Please use 'npm run rebuild-all' instead\" && exit 1",
     "start": "cd server && node index.js",
     "bench": "cd webdriver-ts && cross-env LANG=\"en_US.UTF-8\" node dist/benchmarkRunner.js",
     "checkCSP": "cd webdriver-ts && cross-env LANG=\"en_US.UTF-8\" node dist/isCSPCompliant.js",

webdriver-ts-results/src/reducer.ts

@@ -20,11 +20,7 @@ import {
   knownIssues,
 } from "./Common";
 
-const benchmarks = rawBenchmarks.filter(
-  (benchmark) =>
-    benchmark.id !== "32_startup-bt" &&
-    benchmark.id !== "33_startup-mainthreadcost",
-);
+const benchmarks = rawBenchmarks;
 
 const results: Result[] = rawResults.map((result) => {
   const values: { [k: string]: ResultValues } = {};

webdriver-ts-results/src/results.ts

@@ -37,20 +37,21 @@ export const benchStartupMainThreadWorkCost: StartupBenchmarkInfo = {
   type: BenchmarkType.STARTUP,
 };
 
-export const benchStartupTotalBytes: StartupBenchmarkInfo = {
-  id: "34_startup-totalbytes",
-  label: "total kilobyte weight",
-  description: () => "network transfer cost (post-compression) of all the resources loaded into the page.",
-  property: "total-byte-weight",
-  fn: toKb,
+export const benchStartupMainInteractive: StartupBenchmarkInfo = {
+  id: "34_startup-interactive",
+  label: "interactive",
+  description: () => "Time to Interactive is the amount of time it takes for the page to become fully interactive.",
+  property: "interactive",
+  fn: id,
   type: BenchmarkType.STARTUP,
 };
 
+
 export const subbenchmarks = [
   benchStartupConsistentlyInteractive,
   benchStartupBootup,
   benchStartupMainThreadWorkCost,
-  benchStartupTotalBytes,
+  benchStartupMainInteractive,
 ];
 
 export class BenchmarkLighthouse implements BenchmarkImpl {

webdriver-ts/results.json

@@ -59,7 +59,7 @@ async function runLighthouse(
       await chrome.kill();
       throw error;
     }
-    if (config.LOG_DEBUG) console.log("lighthouse result", results);
+    if (config.LOG_DEBUG) console.log("lighthouse result", JSON.stringify(results));
 
     return startupBenchmarks.map((bench) => ({
         benchmark: bench,

webdriver-ts/src/benchmarksLighthouse.ts

@@ -94,7 +94,7 @@ const tracePaintEventNames = [
   "Paint",
   "Layerize",
   "PrePaint"
-  // including "PrePaint" causes longer duraations as reported by chrome
+  // including "PrePaint" causes longer durations as reported by chrome
 ];
 
 export function extractRelevantTraceEvents(config: Config, relevantEventNames: string[], entries: any[], includeClick: boolean) {
@@ -430,12 +430,13 @@ export async function computeResultsFromTrace(
   for (let ev of eventsWithin) {
     intervals = newContainedInterval(ev, intervals);
   }
-  if (intervals.length > 1) {
-    console.log(`*** More than 1 interval ${intervals.length} for ${fileName}`, intervals);
-  } else {
-    console.log(`1 interval for ${fileName}`, intervals);
+  if (config.LOG_DETAILS) {
+    if (intervals.length > 1) {
+      console.log(`*** More than 1 interval ${intervals.length} for ${fileName}`, intervals);
+    } else {
+      console.log(`1 interval for ${fileName}`, intervals);
+    }
   }
-
   let res = intervals.reduce((p, c) => p + (c.end - c.start), 0) / 1000.0;
   return res;
 }