Skip to content

Commit be6d202

Browse files
committed
fix the error from #1619
1 parent f7567bf commit be6d202

File tree

3 files changed

+7
-6
lines changed

3 files changed

+7
-6
lines changed

cli/rebuild-single-framework.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -19,18 +19,18 @@ Pass list of frameworks
1919
*
2020
* @param {Object} options
2121
* @param {string[]} options.frameworks
22-
* @param {boolean} options.useCi
22+
* @param {boolean} options.ci
2323
*/
24-
export function rebuildSingleFramework({ frameworks, useCi }) {
25-
console.log("Rebuild single:", "ci", useCi, "frameworks", frameworks);
24+
export function rebuildSingleFramework({ frameworks, ci }) {
25+
console.log("Rebuild single:", "ci", ci, "frameworks", frameworks);
2626

2727
if (frameworks.length === 0) {
2828
console.log("ERROR: Missing arguments. Command: rebuild-single keyed/framework1 non-keyed/framework2 ...");
2929
process.exit(1);
3030
}
3131

3232
try {
33-
rebuildFrameworks(frameworks, useCi);
33+
rebuildFrameworks(frameworks, ci);
3434

3535
rebuildCheckSingle({ frameworks });
3636
} catch (error) {

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@
2020
"install-server": "cd server && npm ci",
2121
"install-webdriver-ts-results": "cd webdriver-ts-results && npm ci",
2222
"install-local": "npm run install-webdriver-ts && npm run install-webdriver-ts-results && npm run install-server",
23-
"rebuild": "node cli.js rebuild-songle -f",
23+
"rebuild": "node cli.js rebuild-single -f",
2424
"rebuild-ci": "node cli.js rebuild-single --ci -f",
2525
"zip": "node cli.js zip",
2626
"format": "prettier . \"!(broken-frameworks|frameworks)/**/*\" -w",

webdriver-ts/src/isCSPCompliant.ts

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -93,10 +93,11 @@ async function runBench(
9393
const hint = cspCheckSucessful ? "The flag 1139 should be removed" : "The flag 1139 should be added";
9494
console.log(`ERROR: CSP is incorrectly categorized for ${runFrameworks[i].fullNameWithKeyedAndVersion} . ${hint}`);
9595
cspCheckSucessful = false;
96+
allCorrect = false;
9697
}
97-
allCorrect = allCorrect && cspCheckSucessful;
9898
}
9999
} finally {
100+
await page.goto(`http://${benchmarkOptions.host}:${benchmarkOptions.port}/csp/disable`);
100101
await page.close();
101102
await browser.close();
102103
}

0 commit comments

Comments
 (0)