Skip to content

Commit c6a15a1

Browse files
committed
Merge branch 'master_slingjs_14-3-0' of https://github.com/puckowski/js-framework-benchmark into puckowski-master_slingjs_14-3-0
2 parents a1d256b + f0d946e commit c6a15a1

File tree

4 files changed

+43
-56
lines changed

4 files changed

+43
-56
lines changed

frameworks/non-keyed/slingjs/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<html lang="en">
33
<head>
44
<meta charset="UTF-8">
5-
<title>Sling.js v14.0.0</title>
5+
<title>Sling.js v14.3.0</title>
66
<link href="/css/currentStyle.css" rel="stylesheet"/>
77
</head>
88
<body>

frameworks/non-keyed/slingjs/package-lock.json

Lines changed: 5 additions & 5 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/non-keyed/slingjs/package.json

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
2-
"name": "js-framework-benchmark-slingjs-14.0.0",
3-
"version": "14.0.0",
4-
"description": "Benchmark for Sling.js 14.0.0 framework",
2+
"name": "js-framework-benchmark-slingjs-14.3.0",
3+
"version": "14.3.0",
4+
"description": "Benchmark for Sling.js 14.3.0 framework",
55
"js-framework-benchmark": {
66
"frameworkVersionFromPackage": "slingjs"
77
},
@@ -21,6 +21,6 @@
2121
},
2222
"dependencies": {
2323
"@babel/plugin-transform-spread": "^7.16.7",
24-
"slingjs": "14.0.0"
24+
"slingjs": "14.3.0"
2525
}
2626
}

frameworks/non-keyed/slingjs/src/controller.js

Lines changed: 33 additions & 46 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import { markup, textNode, detectChanges, renderElement, wrapWithChangeDetector } from '../node_modules/slingjs/sling.min.es5';
1+
import { markup, textNode, detectChanges, wrapWithChangeDetector, renderElementWithoutClass } from '../node_modules/slingjs/sling.min.es5';
22
var { Store } = require('./store.es6');
33

44
export class ControllerComponent {
@@ -62,65 +62,51 @@ export class ControllerComponent {
6262
}
6363

6464
makeTableRow(d) {
65-
const rootNode = renderElement(markup('tr', {
66-
attrs: {
65+
const rootNode = renderElementWithoutClass('tr', {
6766
...d.id === this.selected() && { class: 'danger' },
6867
onclick: this.select.bind(this, d.id),
69-
onremove: this.delete.bind(this, d.id)
70-
},
71-
children: [
72-
markup('td', {
73-
attrs: {
68+
}, [
69+
renderElementWithoutClass('td', {
7470
'class': 'col-md-1'
75-
},
76-
children: [
77-
textNode(d.id)
71+
}, [
72+
d.id
7873
]
79-
}),
80-
markup('td', {
81-
attrs: {
74+
),
75+
renderElementWithoutClass('td', {
8276
'class': 'col-md-4',
83-
},
84-
children: [
85-
markup('a', {
86-
attrs: {
87-
'href': '#',
88-
onclick: this.select.bind(this, d.id)
89-
},
90-
children: [
91-
textNode(d.label)
77+
}, [
78+
renderElementWithoutClass('a', {
79+
'href': '#'
80+
}, [
81+
d.label
9282
]
93-
})
83+
)
9484
]
95-
}),
96-
markup('td', {
97-
attrs: {
85+
),
86+
renderElementWithoutClass('td', {
9887
'class': 'col-md-1',
99-
},
100-
children: [
101-
markup('a', {
102-
attrs: {
88+
}, [
89+
renderElementWithoutClass('a', {
10390
'href': '#',
10491
onclick: this.delete.bind(this, d.id)
105-
},
106-
children: [
107-
markup('span', {
108-
attrs: {
92+
}, [
93+
renderElementWithoutClass('span', {
10994
'class': 'glyphicon glyphicon-remove',
11095
'aria-hidden': 'true'
111-
}
112-
})
96+
}, [
97+
]
98+
)
11399
]
114-
})
100+
)
115101
]
116-
}),
117-
markup('td', {
118-
attrs: {
102+
),
103+
renderElementWithoutClass('td', {
119104
'class': 'col-md-6'
120-
}
121-
})
105+
}, [
106+
]
107+
)
122108
]
123-
}));
109+
);
124110

125111
rootNode.$label = rootNode.children[1].children[0];
126112
rootNode.$id = rootNode.children[0];
@@ -137,7 +123,8 @@ export class ControllerComponent {
137123
children: [
138124
markup('div', {
139125
attrs: {
140-
'class': 'jumbotron'
126+
'class': 'jumbotron',
127+
'sldirective': 'useexisting'
141128
},
142129
children: [
143130
markup('div', {
@@ -152,7 +139,7 @@ export class ControllerComponent {
152139
children: [
153140
markup('h1', {
154141
children: [
155-
textNode('Sling.js 14.0.0')
142+
textNode('Sling.js 14.3.0')
156143
]
157144
})
158145
]

0 commit comments

Comments
 (0)