Skip to content

Commit c8560e6

Browse files
committed
Merge branch 'fabiospampinato-voby-0.25.0'
2 parents c359d3b + d2285c2 commit c8560e6

File tree

2 files changed

+6
-5
lines changed

2 files changed

+6
-5
lines changed

frameworks/keyed/voby/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "js-framework-benchmark-voby",
3-
"version": "0.23.2",
3+
"version": "0.27.7",
44
"main": "dist/main.js",
55
"js-framework-benchmark": {
66
"frameworkVersionFromPackage": "voby"
@@ -16,7 +16,7 @@
1616
"url": "https://github.com/krausest/js-framework-benchmark.git"
1717
},
1818
"dependencies": {
19-
"voby": "0.23.2"
19+
"voby": "0.27.7"
2020
},
2121
"devDependencies": {
2222
"esbuild": "0.14.39"

frameworks/keyed/voby/src/main.tsx

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -110,8 +110,8 @@ const Button = ({ id, text, onClick }: { id: string | number, text: string, onCl
110110
</div>
111111
);
112112

113-
const Row = template (({ id, label, className, onSelect, onRemove }: { id: FunctionMaybe<string | number>, label: FunctionMaybe<string>, className: FunctionMaybe<string>, onSelect: ObservableMaybe<(( event: MouseEvent ) => any)>, onRemove: ObservableMaybe<(( event: MouseEvent ) => any)> }): JSX.Element => (
114-
<tr className={className}>
113+
const Row = template (({ id, label, className, onSelect, onRemove }: { id: FunctionMaybe<string | number>, label: FunctionMaybe<string>, className: FunctionMaybe<Record<string, FunctionMaybe<boolean>>>, onSelect: ObservableMaybe<(( event: MouseEvent ) => any)>, onRemove: ObservableMaybe<(( event: MouseEvent ) => any)> }): JSX.Element => (
114+
<tr class={className}>
115115
<td class="col-md-1">{id}</td>
116116
<td class="col-md-4">
117117
<a onClick={onSelect}>{label}</a>
@@ -153,7 +153,8 @@ const App = (): JSX.Element => {
153153
<For values={$data}>
154154
{( datum: IDatum ) => {
155155
const {id, label} = datum;
156-
const className = () => isSelected ( id ) ? 'danger' : '';
156+
const selected = isSelected ( id );
157+
const className = { danger: selected };
157158
const onSelect = select.bind ( undefined, id );
158159
const onRemove = remove.bind ( undefined, id );
159160
const props = {id, label, className, onSelect, onRemove};

0 commit comments

Comments
 (0)