simplify and improve row selection logic

Author: dsvorc41

README.md

@@ -309,7 +309,7 @@ After that you can check all results in [http://localhost:8080/webdriver-ts/tabl
     3. Visit your page in the browser (URL follows the folder structure): `http://localhost:8080/frameworks/keyed/fast/index.html`
     4. Note: Its important to always start the server from the root, because that way you'll get access to global CSS that all apps must share
 5. Add the "action triggers" - buttons that all apps must have (see `frameworks/keyed/vanillajs/index.html`)
-   1. Note: Action triggers are simply buttons that are used to run the benchmarks (adding rows, deleting rows, swapping them, etc). Those buttons can be static HTML, or you can render them with your framework of choice 
+   1. Note: Action triggers are simply buttons that are used to run the benchmarks (adding rows, deleting rows, swapping them, etc). Those buttons can be static HTML, or you can render them dynamically (with JS) with your framework of choice 
    2. Make sure your HTML elements have the same classes and structure as VanillaJS, otherwise benchmarks won't be able to find your elements on the page, and you will not get the global CSS (Bootstrap)
    3. Add the html example below and open the page. You should see nicely formatted elements on the page, like in the GIF image below.
    4. Example for action triggers
@@ -392,7 +392,7 @@ After that you can check all results in [http://localhost:8080/webdriver-ts/tabl
 6. Generate dummy data for rendering
    1. See `frameworks/keyed/fast/src/utils/build-dummy-data.ts` as an example
    2. Note: `id` is an important attribute and it must be initialized as `1`, and continuously incremented. The only time `id` resets back to `1` is when the page reloads - otherwise it should just keep incrementing each time a new row is created. Doing anything else will cause errors when benchmarks try to find elements with specific IDs. Trust me, I learned the hard way.
-7. . Your app needs to support several actions that correspond to "Action triggers" listed above. Here's an example from Fast framework:
+7. . Your app needs to support several actions that correspond to "Action triggers" listed above. Here's an example from Fast framework `frameworks\keyed\fast\src\App.ts` and `frameworks\keyed\fast\src\components\Table.ts`:
    1. Code example:
       ```typescript
         export class BenchmarkApp extends FASTElement {
@@ -404,25 +404,29 @@ After that you can check all results in [http://localhost:8080/webdriver-ts/tabl
           swapTwoRows() {}
           deleteSingleRow(rowId: number) {}
         }
+
+        export class Table extends FASTElement {
+          selectRow(rowId: number) {}
+        }
       ```
-    2. Note: your app doesn't need methods with the same name - you should write idiomatic code and follow the best practices of your framework of choice. The example above is just to give you an idea of which operations must be supported, but how you choose to implement those methods can be very different from one framework to the next. 
-8. Manually testing your app - do this before you run the benchmarks
+    1. Note: your app doesn't need methods with the same name - you should write idiomatic code and follow the best practices of your framework of choice. The example above is just to give you an idea of which operations must be supported, but how you choose to implement those methods can be very different from one framework to the next. 
+1. Manually testing your app - do this before you run the benchmarks
    1. Open your page and click on the buttons, make sure your app adds 1000 rows, then removes them, or swaps them, or adds/removes 10,000 rows. 
    2. To do this, you'll probably need to watch your local files and compile them into some sort of a bundle, like `frameworks\keyed\fast\dist\bundle.js` which will be loaded through a script tag in your HTML file
    3. For example, in Fast folder we have webpack watching our files: ` "build-dev": "rimraf dist && webpack --config webpack.config.js --watch --mode=development",` 
    4. That means we have two terminal tabs running
       1. One for the server from the root folder `npm start`
       2. And another in our local folder where webpack is watching the files
-9. Run the single benchmark for your framework
+2. Run the single benchmark for your framework
    1.  Once you manually verified that everything works as expected, run a single benchmark and make sure all of the tests are running
    2.  If you forgot something, one of the benchmarks will probably fail - for example it won't be able to find an element on the page or similar
    3.  Keep the server in the root folder running `npm start`, and in another terminal tab, also from the root folder run `npm run bench -- --framework keyed/fast` (or whatever is your framework `keyed/react`, `keyed/angular`, etc.).
    4.  The benchmark runner will open and close Chrome multiple times. The whole thing will take a couple of minutes.
-10. Optional: run the benchmark for VanillaJS as comparison
+3.  Optional: run the benchmark for VanillaJS as comparison
     1.  ` npm run bench -- --framework keyed/vanillajs`
-11. Build the report
+4.  Build the report
     1. `npm run results`
-12. Open the report in your browser (NOTE: the server must still be running if you want to see this page)
+5.  Open the report in your browser (NOTE: the server must still be running if you want to see this page)
     1. `http://localhost:8080/webdriver-ts-results/table.html`
 
 ## 4.1 Building the app

frameworks/keyed/fast/src/components/Table.ts

@@ -62,15 +62,12 @@ export class Table extends FASTElement {
 
     if (target.classList.contains('lbl')) {
       const rowId = target.dataset['rowId'];
-      this.toggleSelectRow(Number(rowId));
+      this.selectRow(Number(rowId));
       return;
     }
   }
 
-  toggleSelectRow(rowId: number) {
-    const rowIndex = this.rows.findIndex(row => row.id === rowId);
-    if (rowIndex > -1) {
-      this.selectedRowId = rowIndex + 1;
-    }
+  private selectRow(rowId: number) {
+    this.selectedRowId = rowId;
   }
 }