mousedown is cheating - switch to mouseup

Author: Niedzwiedzw

frameworks/non-keyed/korvin/js-framework-benchmark-korvin_bg.wasm

@@ -142,13 +142,12 @@ enum AppMessage {
 
 fn app(communicator: Communicator<AppMessage>, App { data, selected }: &App) -> ElementBuilder {
     let div = |class: &str| "div".attribute("class", class);
-    let mousedown_send = move |message| move |_: MouseEvent| communicator.send(message);
-    let element_mousedown_send = |element: ElementBuilder, message| {
-        element.event(message, "mousedown", mousedown_send(message))
-    };
+    let mouseup_send = move |message| move |_: MouseEvent| communicator.send(message);
+    let element_mouseup_send =
+        |element: ElementBuilder, message| element.event(message, "mouseup", mouseup_send(message));
 
     let message_button =
-        |id, text, message| button(id, text, |button| element_mousedown_send(button, message));
+        |id, text, message| button(id, text, |button| element_mouseup_send(button, message));
     let jumbotron = div("jumbotron")
         .child(div("col-md-6").child("h1".text("Korvin")))
         .child(div("col-md-6"))
@@ -194,15 +193,15 @@ fn app(communicator: Communicator<AppMessage>, App { data, selected }: &App) ->
             }
             let td = |class: &str| "td".attribute("class", class);
             let row = {
-                td("col-md-4").child(element_mousedown_send(
+                td("col-md-4").child(element_mouseup_send(
                     "a".text(label.as_str()),
                     AppMessage::SetSelected(*id),
                 ))
             };
             tr.child(td("col-md-1").text(id.to_string().as_str()))
                 .child(row)
                 .child(
-                    td("col-md-1").child(element_mousedown_send(
+                    td("col-md-1").child(element_mouseup_send(
                         "a".child(
                             "span"
                                 .attribute("class", "glyphicon glyphicon-remove")

frameworks/non-keyed/korvin/src/main.rs

@@ -73,24 +73,24 @@ export const results: RawResult[]=[
 {"f":"elm-v0.19.1-3-non-keyed","b":"32_startup-bt","v":{"DEFAULT":[13.543999999999993]}},
 {"f":"elm-v0.19.1-3-non-keyed","b":"33_startup-mainthreadcost","v":{"DEFAULT":[175.12399999999994]}},
 {"f":"elm-v0.19.1-3-non-keyed","b":"34_startup-totalbytes","v":{"DEFAULT":[160.677734375]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"01_run1k","v":{"total":[3.202,3.243,3.248,3.278,3.367,3.374,3.381,3.388,3.395,3.42,3.463,3.468,3.492,3.571,3.828],"script":[0.005,0.005,0.004,0.004,0.005,0.005,0.005,0.005,0.005,0.006,0.004,0.004,0.005,0.005,0.007]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"02_replace1k","v":{"total":[1.697,1.709,1.753,1.787,1.839,1.858,1.864,1.865,1.868,1.871,1.922,2.046,2.066,2.119,2.188],"script":[0.004,0.004,0.004,0.004,0.005,0.004,0.005,0.004,0.004,0.005,0.004,0.004,0.006,0.006,0.005]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"03_update10th1k_x16","v":{"total":[5.985,6.374,6.61,6.674,6.692,6.694,6.757,6.803,6.904,6.971,7.12,7.214,7.662,9.106,9.71],"script":[0.004,0.004,0.004,0.004,0.004,0.005,0.004,0.005,0.005,0.004,0.005,0.007,0.004,0.013,0.006]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"04_select1k","v":{"total":[4.154,4.33,4.703,4.739,4.872,4.9,4.927,5.02,5.043,5.044,5.164,5.235,5.255,5.278,5.344,5.375,5.409,5.441,5.448,5.518,5.531,5.56,5.641,5.704,5.751],"script":[0.008,0.004,0.004,0.003,0.004,0.004,0.004,0.004,0.004,0.004,0.004,0.004,0.004,0.004,0.694,0.004,0.004,0.004,0.006,0.004,0.004,0.005,0.004,0.004,0.004]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"05_swap1k","v":{"total":[5.856,6.253,6.388,6.467,6.518,6.578,6.64,6.721,6.735,6.926,6.974,7.037,7.179,7.464,8.884],"script":[0.004,0.005,0.006,0.005,0.005,0.004,0.004,0.005,0.005,0.004,0.005,0.004,0.005,0.004,0.005]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"06_remove-one-1k","v":{"total":[0.215,6.063,6.098,6.122,6.156,6.158,6.161,6.207,6.262,6.428,6.548,6.614,6.705,8.192,8.555],"script":[0.01,0.004,0.004,0.004,0.005,0.004,0.004,0.005,0.004,0.004,0.005,0.004,0.004,0.004,0.005]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"07_create10k","v":{"total":[36.191,36.954,38.657,38.897,39.047,39.084,39.445,39.547,40.191,40.477,40.931,42.405,44.48,48.282,49.981],"script":[0.004,0.004,0.004,0.005,0.004,0.004,0.005,0.01,0.004,0.004,0.005,0.005,0.004,0.005,0.004]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"08_create1k-after1k_x2","v":{"total":[4.742,4.95,5.1,5.135,5.154,5.171,5.26,5.299,5.345,5.63,5.763,6.066,6.8,6.809,9.909],"script":[0.008,0.004,0.008,0.004,0.004,0.004,0.005,0.004,0.004,0.004,0.005,0.004,0.005,0.004,0.005]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"09_clear1k_x8","v":{"total":[2.069,2.39,2.399,2.406,2.623,2.676,2.702,2.779,2.88,2.917,3.011,3.089,3.105,3.166,3.27],"script":[0.004,0.004,0.008,0.041,0.004,0.003,0.004,0.533,0.004,0.004,0.004,0.004,0.003,0.006,0.004]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"21_ready-memory","v":{"DEFAULT":[1.7117633819580078]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"01_run1k","v":{"total":[62.634,63.035,63.16,63.164,63.423,63.439,63.523,63.62,63.692,63.904,63.912,64.015,64.015,64.282,66.296],"script":[0.009,0.018,0.015,0.01,0.011,0.009,0.009,0.01,0.009,0.009,0.009,0.009,0.009,0.01,0.009]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"02_replace1k","v":{"total":[26.646,26.688,26.734,26.826,26.93,26.981,27.01,27.087,27.113,27.115,27.121,27.125,27.193,27.343,27.732],"script":[0.009,0.009,0.009,0.009,0.008,0.008,0.009,0.009,0.008,0.012,0.009,0.016,0.014,0.009,0.01]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"03_update10th1k_x16","v":{"total":[35.769,35.853,35.962,36.088,36.116,36.212,36.543,36.602,36.64,37.178,37.398,37.451,37.471,37.6,37.763],"script":[0.012,0.01,0.007,0.007,0.007,0.008,0.006,0.011,0.008,0.007,0.008,0.013,0.008,0.008,0.01]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"04_select1k","v":{"total":[5.948,6.14,6.426,6.561,6.713,6.717,6.762,6.834,6.855,6.895,7.059,7.081,7.118,7.125,7.145,7.258,7.264,7.309,7.323,7.329,7.464,7.704,7.856,7.968,10.251],"script":[0.007,0.006,0.006,0.007,0.007,0.011,0.007,0.015,0.006,0.007,0.334,0.006,0.008,0.005,0.006,0.006,0.774,0.007,0.734,0.01,0.007,0.011,0.007,0.01,0.007]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"05_swap1k","v":{"total":[27.212,27.414,28.896,29.197,29.378,29.432,29.464,29.527,30.076,30.107,30.167,30.503,30.794,33.571,34.078],"script":[0.006,0.006,0.006,0.011,0.007,0.006,0.006,0.008,0.014,0.006,0.008,0.01,0.006,0.007,0.007]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"06_remove-one-1k","v":{"total":[57.521,58.212,58.433,58.522,58.542,58.918,58.959,59.024,59.068,59.469,59.716,59.948,60.071,60.192,68.167],"script":[0.009,0.008,0.009,0.009,0.008,0.016,0.272,0.009,0.008,0.009,0.008,0.011,0.008,0.008,0.008]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"07_create10k","v":{"total":[740.271,741.266,741.763,743.601,743.957,744.659,745.485,746.675,749.045,749.718,753.33,763.884,771.962,774.701,777.537],"script":[0.012,0.011,0.026,0.012,0.012,0.013,0.013,0.013,0.01,0.029,0.011,0.011,0.013,0.012,0.013]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"08_create1k-after1k_x2","v":{"total":[69.119,69.316,69.625,70.201,70.314,70.395,70.834,70.848,71.191,71.34,71.814,72.456,72.911,73.079,73.939],"script":[0.009,0.01,0.015,0.009,0.008,0.009,0.009,0.01,0.01,0.01,0.01,0.013,0.011,0.014,0.009]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"09_clear1k_x8","v":{"total":[3.133,3.164,3.213,3.332,3.526,3.533,3.539,3.56,3.644,3.645,3.743,3.964,4.079,4.313,4.41],"script":[0.008,0.007,0.007,0.007,0.007,0.007,0.008,0.007,0.007,0.014,0.007,0.009,0.621,0.007,0.007]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"21_ready-memory","v":{"DEFAULT":[1.711812973022461]}},
 {"f":"korvin-v0.2.1-non-keyed","b":"22_run-memory","v":{"DEFAULT":[7.519064903259277]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"23_update5-memory","v":{"DEFAULT":[9.652976989746094]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"25_run-clear-memory","v":{"DEFAULT":[5.870012283325195]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"26_run-10k-memory","v":{"DEFAULT":[58.205867767333984]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"31_startup-ci","v":{"DEFAULT":[1880.625]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"32_startup-bt","v":{"DEFAULT":[44.176000000000016]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"33_startup-mainthreadcost","v":{"DEFAULT":[194.44400000000005]}},
-{"f":"korvin-v0.2.1-non-keyed","b":"34_startup-totalbytes","v":{"DEFAULT":[391.69140625]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"23_update5-memory","v":{"DEFAULT":[9.65109634399414]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"25_run-clear-memory","v":{"DEFAULT":[5.870084762573242]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"26_run-10k-memory","v":{"DEFAULT":[58.89329528808594]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"31_startup-ci","v":{"DEFAULT":[1878.895]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"32_startup-bt","v":{"DEFAULT":[40.46]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"33_startup-mainthreadcost","v":{"DEFAULT":[190.98799999999997]}},
+{"f":"korvin-v0.2.1-non-keyed","b":"34_startup-totalbytes","v":{"DEFAULT":[391.67578125]}},
 {"f":"react-v18.2.0-non-keyed","b":"01_run1k","v":{"total":[85.603,86.445,87.3,87.383,87.539,87.878,88.586,88.722,90.207,90.5,90.9,91.213,91.51,92.951,95.223],"script":[22.116,21.751,23.073,22.772,22.581,23.249,22.58,22.006,23.598,22.626,27.675,22.496,24.185,23.716,27.659]}},
 {"f":"react-v18.2.0-non-keyed","b":"02_replace1k","v":{"total":[34.993,36.542,36.62,37.108,37.115,37.437,37.932,38.071,38.429,38.876,40.03,40.192,40.558,40.689,42.619],"script":[8.814,10.034,9.859,10.034,9.884,9.992,10.949,10.62,10.507,12.544,10.941,12.697,10.655,11.84,11.528]}},
 {"f":"react-v18.2.0-non-keyed","b":"03_update10th1k_x16","v":{"total":[42.982,44.724,45.117,45.199,47.243,47.742,49.424,50.211,50.246,53.792,56.972,57.178,57.538,58.725,60.538],"script":[9.583,9.938,10.899,10.067,9.798,11.104,12.856,9.806,10.947,11.946,10.654,12.392,11.54,10.762,11.762]}},