Skip to content

Commit d0114d0

Browse files
committed
Merge branch 'Linkontoask-master'
2 parents 45b259d + 8d95cac commit d0114d0

File tree

8 files changed

+100
-91
lines changed

8 files changed

+100
-91
lines changed

frameworks/keyed/gyron/package-lock.json

Lines changed: 32 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/keyed/gyron/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
"url": "https://github.com/krausest/js-framework-benchmark.git"
2121
},
2222
"devDependencies": {
23-
"@gyron/babel-plugin-jsx": "0.0.13",
23+
"@gyron/babel-plugin-jsx": "0.0.16",
2424
"babel-loader": "8.2.5",
2525
"webpack": "5.49.0",
2626
"webpack-cli": "4.7.2"
2727
},
2828
"dependencies": {
29-
"gyron": "0.0.13"
29+
"gyron": "0.0.16"
3030
}
3131
}

frameworks/keyed/gyron/src/main.jsx

Lines changed: 16 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,16 @@ function swap() {
113113
const d998 = _rows[998];
114114
_rows[1] = d998;
115115
_rows[998] = d1;
116-
rows.value = _rows.slice();
117116
}
118117
}
119118

119+
function remove(id) {
120+
rows.value.splice(
121+
rows.value.findIndex((d) => d.id === id),
122+
1
123+
);
124+
}
125+
120126
const Button = FC(({ text, id, onClick }) => {
121127
return (
122128
<div class="col-sm-6 smallpad">
@@ -144,19 +150,16 @@ const ButtonGroup = FC(() => {
144150
});
145151

146152
const Table = FC(() => {
147-
function remove(id) {
148-
rows.value.splice(
149-
rows.value.findIndex((d) => d.id === id),
150-
1
151-
);
152-
}
153-
154153
return (
155154
<table class="table table-hover table-striped test-data">
156155
<tbody>
157156
{rows.value.map(({ id, label }) => {
158157
return (
159-
<tr key={id} class={id === selected.value ? "danger" : null}>
158+
<tr
159+
key={id}
160+
class={id === selected.value ? "danger" : null}
161+
memo={[id === selected.value, label]}
162+
>
160163
<td class="col-md-1">{id}</td>
161164
<td class="col-md-4">
162165
<a onClick={() => select(id)}>{label}</a>
@@ -185,7 +188,10 @@ const Main = FC(() => {
185188
<ButtonGroup />
186189
</div>
187190
<Table />
188-
<span class="preloadicon glyphicon glyphicon-remove" aria-hidden="true"></span>
191+
<span
192+
class="preloadicon glyphicon glyphicon-remove"
193+
aria-hidden="true"
194+
></span>
189195
</div>
190196
);
191197
});

frameworks/keyed/gyron/webpack.config.js

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,4 @@
11
const path = require("path");
2-
const webpack = require("webpack");
32

43
module.exports = {
54
mode: "production",

frameworks/non-keyed/gyron/package-lock.json

Lines changed: 32 additions & 32 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

frameworks/non-keyed/gyron/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,12 +20,12 @@
2020
"url": "https://github.com/krausest/js-framework-benchmark.git"
2121
},
2222
"devDependencies": {
23-
"@gyron/babel-plugin-jsx": "0.0.13",
23+
"@gyron/babel-plugin-jsx": "0.0.16",
2424
"babel-loader": "8.2.5",
2525
"webpack": "5.49.0",
2626
"webpack-cli": "4.7.2"
2727
},
2828
"dependencies": {
29-
"gyron": "0.0.13"
29+
"gyron": "0.0.16"
3030
}
3131
}

frameworks/non-keyed/gyron/src/main.jsx

Lines changed: 16 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -113,10 +113,16 @@ function swap() {
113113
const d998 = _rows[998];
114114
_rows[1] = d998;
115115
_rows[998] = d1;
116-
rows.value = _rows.slice();
117116
}
118117
}
119118

119+
function remove(id) {
120+
rows.value.splice(
121+
rows.value.findIndex((d) => d.id === id),
122+
1
123+
);
124+
}
125+
120126
const Button = FC(({ text, id, onClick }) => {
121127
return (
122128
<div class="col-sm-6 smallpad">
@@ -130,7 +136,7 @@ const Button = FC(({ text, id, onClick }) => {
130136
const ButtonGroup = FC(() => {
131137
return (
132138
<div class="row">
133-
<h1 class="col-md-6">Gyron.js NonKeyed</h1>
139+
<h1 class="col-md-6">Gyron.js Keyed</h1>
134140
<div class="col-md-6 row">
135141
<Button text="Create 1,000 rows" id="run" onClick={run} />
136142
<Button text="Create 10,000 rows" id="runlots" onClick={addLots} />
@@ -144,19 +150,15 @@ const ButtonGroup = FC(() => {
144150
});
145151

146152
const Table = FC(() => {
147-
function remove(id) {
148-
rows.value.splice(
149-
rows.value.findIndex((d) => d.id === id),
150-
1
151-
);
152-
}
153-
154153
return (
155154
<table class="table table-hover table-striped test-data">
156155
<tbody>
157156
{rows.value.map(({ id, label }) => {
158157
return (
159-
<tr class={id === selected.value ? "danger" : null}>
158+
<tr
159+
class={id === selected.value ? "danger" : null}
160+
memo={[id === selected.value, label]}
161+
>
160162
<td class="col-md-1">{id}</td>
161163
<td class="col-md-4">
162164
<a onClick={() => select(id)}>{label}</a>
@@ -185,7 +187,10 @@ const Main = FC(() => {
185187
<ButtonGroup />
186188
</div>
187189
<Table />
188-
<span class="preloadicon glyphicon glyphicon-remove" aria-hidden="true"></span>
190+
<span
191+
class="preloadicon glyphicon glyphicon-remove"
192+
aria-hidden="true"
193+
></span>
189194
</div>
190195
);
191196
});

0 commit comments

Comments
 (0)