improve eslint's happiness

Author: krausest

webdriver-ts/src/benchmarkRunner.ts

@@ -358,7 +358,7 @@ async function main() {
   }
 
   let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
-  let frameworkArgument = !args.framework ? allArgs : args.framework;
+  let frameworkArgument = args.framework ? args.framework : allArgs;
   console.log("args", args, "allArgs", allArgs);
 
   if (process.env.HOST) {
@@ -378,7 +378,8 @@ async function main() {
   let runFrameworks: FrameworkData[];
   let matchesDirectoryArg = (directoryName: string) =>
     frameworkArgument.length === 0 || frameworkArgument.some((arg: string) => arg == directoryName);
-  runFrameworks = (await initializeFrameworks(benchmarkOptions, matchesDirectoryArg)).filter(
+  let frameworks = await initializeFrameworks(benchmarkOptions, matchesDirectoryArg);
+  runFrameworks = frameworks.filter(
     (f) => f.keyed || config.BENCHMARK_RUNNER !== BenchmarkRunner.WEBDRIVER_AFTERFRAME
   );
 

webdriver-ts/src/isKeyed.ts

@@ -39,7 +39,7 @@ let benchmarkOptions: BenchmarkOptions = {
 };
 
 let allArgs = args._.length <= 2 ? [] : args._.slice(2, args._.length);
-let frameworkArgument = !args.framework ? allArgs : args.framework;
+let frameworkArgument = args.framework ? args.framework : allArgs;
 console.log("args", args, "allArgs", allArgs);
 
 let init = (shadowRootName: string) => `

webdriver-ts/src/timeline.ts

@@ -419,9 +419,7 @@ export async function parseCPUTrace(
   let results: CPUBenchmarkResult[] = [];
   for (let i = 0; i < benchmarkOptions.numIterationsForCPUBenchmarks; i++) {
     let trace = `${fileNameTrace(framework, benchmarkInfo, i, benchmarkOptions)}`;
-    if (!fs.existsSync(trace)) {
-      throw new Error(`Trace file ${trace} does not exist`);
-    } else {
+    if (fs.existsSync(trace)) {
       console.log("analyzing trace", trace);
       try {
         let result = await computeResultsCPU(trace);
@@ -432,6 +430,8 @@ export async function parseCPUTrace(
       } catch (error) {
         console.log(error);
       }
+    } else {
+      throw new Error(`Trace file ${trace} does not exist`);
     }
   }
 

webdriver-ts/src/webdriverAccess.ts

@@ -295,9 +295,9 @@ export function buildDriver(benchmarkOptions: BenchmarkOptions): WebDriver {
   // }
 
   if (benchmarkOptions.headless) {
-    args.push("--headless");
-    args.push("--disable-gpu"); // https://bugs.chromium.org/p/chromium/issues/detail?id=737678
-    args.push("--no-sandbox");
+    args.push("--headless", 
+              "--disable-gpu", 
+              "--no-sandbox");
   }
 
   let caps = new Capabilities({

webdriver-ts/src/webdriverCDPAccess.ts

@@ -322,9 +322,9 @@ export function buildDriver(benchmarkOptions: BenchmarkOptions): WebDriver {
   }
 
   if (benchmarkOptions.headless) {
-    args.push("--headless");
-    args.push("--disable-gpu"); // https://bugs.chromium.org/p/chromium/issues/detail?id=737678
-    args.push("--no-sandbox");
+    args.push("--headless", 
+              "--disable-gpu", 
+              "--no-sandbox");
   }
 
   let caps = new Capabilities({