Skip to content

Commit ec2c5a1

Browse files
committed
use last-resort gc, fixes #1667
1 parent afe45af commit ec2c5a1

File tree

2 files changed

+5
-13
lines changed

2 files changed

+5
-13
lines changed

webdriver-ts/src/forkedBenchmarkRunnerPlaywright.ts

Lines changed: 3 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -60,12 +60,8 @@ function convertError(error: any): string {
6060
}
6161
}
6262

63-
// eslint-disable-next-line @typescript-eslint/no-unused-vars
64-
async function forceGC(page: Page, client?: CDPSession) {
65-
for (let i = 0; i < 7; i++) {
66-
// await client.send('HeapProfiler.collectGarbage');
67-
await page.evaluate("window.gc()");
68-
}
63+
async function forceGC(page: Page) {
64+
await page.evaluate("window.gc({type:'major',execution:'sync',flavor:'last-resort'})");
6965
}
7066

7167
async function runCPUBenchmark(
@@ -128,7 +124,7 @@ async function runCPUBenchmark(
128124
config,
129125
fileNameTrace(framework, benchmark.benchmarkInfo, i, benchmarkOptions)
130126
);
131-
127+
132128
let res = { total: result.duration, script: resultScript, paint: resultPaint };
133129
results.push(res);
134130
console.log(`duration for ${framework.name} and ${benchmark.benchmarkInfo.id}: ${JSON.stringify(res)}`);

webdriver-ts/src/forkedBenchmarkRunnerPuppeteer.ts

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -49,12 +49,8 @@ function convertError(error: any): string {
4949
}
5050
}
5151

52-
// eslint-disable-next-line @typescript-eslint/no-unused-vars
53-
async function forceGC(page: Page, client: CDPSession) {
54-
for (let i = 0; i < 7; i++) {
55-
await client.send("HeapProfiler.collectGarbage");
56-
await page.evaluate("window.gc()");
57-
}
52+
async function forceGC(page: Page) {
53+
await page.evaluate("window.gc({type:'major',execution:'sync',flavor:'last-resort'})");
5854
}
5955

6056
async function runCPUBenchmark(

0 commit comments

Comments
 (0)