fix NaN% and broken compare #1749

Author: krausest

webdriver-ts-results/src/Common.ts

@@ -180,7 +180,7 @@ function colorsForStatisticResult(statisticResult: StatisticResult) {
 }
 
 const statisticComputeColor = function (sign: number, pValue: number): [string, string, StatisticResult] {
-  if (pValue > 0.05) {
+  if (pValue > 0.05 || Number.isNaN(pValue)) {
     return undecided; //['#fff','#000', StatisticResult.Undecided];
   }
   if (sign <= 0) {
@@ -460,17 +460,18 @@ export class ResultTableData {
     // if (benchmark.type === BenchmarkType.CPU) {
     //     factor = Math.max(1, factor);
     // }
-    const conficenceInterval =
+    const confidenceInterval = 
       (1.959964 * (resultValues.standardDeviation || 0)) / Math.sqrt(resultValues.values.length);
-    const conficenceIntervalStr = benchmark.type === BenchmarkType.CPU ? conficenceInterval.toFixed(1) : null;
-    const formattedValue = formatEn.format(value);
+      const confidenceIntervalStr = benchmark.type === BenchmarkType.CPU ? confidenceInterval.toFixed(1) : null;
+      const formattedValue = formatEn.format(value);
+      console.log("confidenceInterval", benchmark.id, framework.name, formattedValue, value, confidenceInterval, confidenceIntervalStr, resultValues.values.length)
 
-    if (!this.compareWith) {
+    if (!this.compareWith || benchmark.type !== BenchmarkType.CPU) {
       return new TableResultValueEntry(
         framework.name,
         value,
         formattedValue,
-        conficenceIntervalStr,
+        confidenceIntervalStr,
         factor,
         factor.toFixed(2),
         computeColor(factor),
@@ -511,7 +512,7 @@ export class ResultTableData {
       framework.name,
       value,
       formattedValue,
-      conficenceIntervalStr,
+      confidenceIntervalStr,
       factor,
       factor.toFixed(2),
       statisticalCol[0],