Merge branch 'krausest:master' into master

Author: antonmak1

README.md

@@ -1,3 +1,5 @@
+**Please note: There's an [issue](https://github.com/krausest/js-framework-benchmark/issues/1655) with chrome 124 such that we don't get reliable values. Currently all PRs are blocked by this issue.**
+
 
 # js-framework-benchmark
 

webdriver-ts-results/src/components/BoxPlotTable/BoxPlotTableChart.tsx

@@ -50,6 +50,7 @@ const BoxPlotTableChart = ({ traces }: Props) => {
       },
       options: {
         animation: false,
+        maintainAspectRatio: false,
         scales: {
           x: {
             type: "category",

webdriver-ts/package-lock.json

@@ -21,27 +21,27 @@
   "author": "",
   "license": "Apache-2.0",
   "devDependencies": {
-    "@types/node": "20.11.0",
-    "@types/ramda": "0.29.9",
-    "@types/selenium-webdriver": "4.1.21",
-    "@types/semver": "7.5.6",
+    "@types/node": "20.12.7",
+    "@types/ramda": "0.29.12",
+    "@types/selenium-webdriver": "4.1.22",
+    "@types/semver": "7.5.8",
     "@types/yargs": "17.0.32",
-    "@vitest/coverage-v8": "^1.2.0",
+    "@vitest/coverage-v8": "^1.5.2",
     "ts-node": "^10.9.2",
-    "typescript": "5.3.3",
-    "vitest": "^1.2.0"
+    "typescript": "5.4.5",
+    "vitest": "^1.5.2"
   },
   "dependencies": {
-    "chromedriver": "120.0.1",
+    "chromedriver": "124.0.1",
     "cross-env": "7.0.3",
-    "lighthouse": "11.4.0",
-    "playwright": "1.40.1",
-    "playwright-firefox": "1.40.1",
-    "playwright-webkit": "1.40.1",
-    "puppeteer-core": "21.7.0",
-    "ramda": "0.29.1",
-    "selenium-webdriver": "4.16.0",
-    "semver": "7.5.4",
+    "lighthouse": "12.0.0",
+    "playwright": "1.43.1",
+    "playwright-firefox": "1.43.1",
+    "playwright-webkit": "1.43.1",
+    "puppeteer-core": "22.7.1",
+    "ramda": "0.30.0",
+    "selenium-webdriver": "4.20.0",
+    "semver": "7.6.0",
     "yargs": "17.7.2"
   }
 }

webdriver-ts/package.json

@@ -93,8 +93,7 @@ async function runBenchmakLoopStartup(
     let res = await forkAndCallBenchmark(framework, benchmarkInfo, benchmarkOptions);
     if (Array.isArray(res.result)) {
       results = results.concat(res.result as StartupBenchmarkResult[]);
-    } 
-    else {
+    } else {
       results.push(res.result);
     }
     if (res.warnings) {
@@ -338,6 +337,7 @@ async function main() {
     .array("framework")
     .array("benchmark")
     .number("count")
+    .number("puppeteerSleep")
     .string("chromeBinary").argv;
 
   console.log("args", args);
@@ -381,8 +381,11 @@ async function main() {
     resultsDirectory: "results",
     tracesDirectory: "traces",
     allowThrottling: !args.nothrottling,
+    puppeteerSleep: args.puppeteerSleep ?? 0,
   };
 
+  config.PUPPETEER_WAIT_MS = benchmarkOptions.puppeteerSleep;
+
   if (args.count) {
     benchmarkOptions.numIterationsForCPUBenchmarks = args.count;
     config.NUM_ITERATIONS_FOR_BENCHMARK_CPU_DROP_SLOWEST_COUNT = 0;
@@ -412,14 +415,12 @@ async function main() {
   let matchesDirectoryArg = (directoryName: string) =>
     frameworkArgument.length === 0 || frameworkArgument.some((arg: string) => arg == directoryName);
   let frameworks = await initializeFrameworks(benchmarkOptions, matchesDirectoryArg);
-  runFrameworks = frameworks.filter(
-    (f) => f.keyed || config.BENCHMARK_RUNNER !== BenchmarkRunner.WEBDRIVER_AFTERFRAME
-  );
+  runFrameworks = frameworks.filter((f) => f.keyed || config.BENCHMARK_RUNNER !== BenchmarkRunner.WEBDRIVER_AFTERFRAME);
 
-  if (args.type=='keyed') {
+  if (args.type == "keyed") {
     runFrameworks = runFrameworks.filter((f) => f.keyed);
     console.log("run only keyed frameworks");
-  } else if (args.type=='non-keyed') {
+  } else if (args.type == "non-keyed") {
     runFrameworks = runFrameworks.filter((f) => !f.keyed);
     console.log("run only non-keyed frameworks");
   }