Skip to content

Commit 02f5016

Browse files
Merge pull request #195 from naresh-webkul/master
fixed broken access control issue for account update
2 parents b0bd5b6 + bf6efcf commit 02f5016

File tree

4 files changed

+13
-6
lines changed

4 files changed

+13
-6
lines changed

packages/Webkul/Admin/src/Http/Controllers/User/AccountController.php

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -46,6 +46,12 @@ public function update()
4646
return redirect()->back();
4747
}
4848

49+
if( isset($data['role_id']) || isset($data['view_permission']) ) {
50+
session()->flash('warning', trans('admin::app.user.account.permission-denied'));
51+
52+
return redirect()->back();
53+
}
54+
4955
if (! $data['password']) {
5056
unset($data['password']);
5157
} else {
@@ -63,4 +69,4 @@ public function update()
6369

6470
return redirect()->route('admin.dashboard.index');
6571
}
66-
}
72+
}

packages/Webkul/Admin/src/Resources/lang/en/app.php

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -716,6 +716,7 @@
716716
'confirm_password' => 'Confirm password',
717717
'password-match' => 'Current password does not match.',
718718
'account-save' => 'Account changes saved successfully.',
719+
'permission-denied' => 'Permission Denied'
719720
]
720721
],
721722

@@ -740,4 +741,4 @@
740741
]
741742
]
742743
];
743-
?>
744+
?>

packages/Webkul/UI/publishable/assets/js/ui.js

Lines changed: 1 addition & 1 deletion
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

packages/Webkul/UI/src/Resources/assets/js/components/datagrid/table-body.vue

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -36,7 +36,7 @@
3636
:key="rowIndex"
3737
v-if="column.type != 'hidden'"
3838
@click="redirectRow(row.redirect_url)"
39-
v-html="getRowContent(row[column.index])"
39+
v-text="getRowContent(row[column.index])"
4040
:title="column.title ? row[column.index] : ''"
4141
:class="[row.redirect_url ? 'cursor-pointer' : '', column.class || column.index ]"
4242
></td>
@@ -174,7 +174,7 @@
174174
type : "success",
175175
message : response.data.message,
176176
});
177-
177+
178178
EventBus.$emit('refresh_table_data', {usePrevious: true});
179179
}
180180
}
@@ -189,4 +189,4 @@
189189
}
190190
}
191191
};
192-
</script>
192+
</script>

0 commit comments

Comments
 (0)