Skip to content

Commit 469a3e1

Browse files
committed
Ensure fields exist before accessing them
1 parent 4af9906 commit 469a3e1

File tree

4 files changed

+13
-0
lines changed

4 files changed

+13
-0
lines changed

tests/Integration/Database/TransactionTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -73,9 +73,11 @@ public function aTransactionKeepsTrackOfMultipleReferences(): void
7373
$secondSnapshot = $transaction->snapshot($secondRef);
7474

7575
$firstCurrentValue = $firstSnapshot->getValue() ?? 0;
76+
assert(is_int($firstCurrentValue));
7677
$newFirstValue = ++$firstCurrentValue;
7778

7879
$secondCurrentValue = $secondSnapshot->getValue() ?? 0;
80+
assert(is_int($secondCurrentValue));
7981
$newSecondValue = ++$secondCurrentValue;
8082

8183
// Set the value without a transaction

tests/Unit/Messaging/CloudMessageTest.php

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -139,10 +139,16 @@ public function messageDataCanBeSetWithAnObjectOrAnArray(): void
139139

140140
$fromObject = CloudMessage::new()->withData(MessageData::fromArray($data));
141141
$serializedFromObject = Json::decode(Json::encode($fromObject), true);
142+
143+
$this->assertArrayHasKey('data', $serializedFromObject);
144+
$this->assertArrayHasKey('key', $serializedFromObject['data']);
142145
$this->assertSame('value', $serializedFromObject['data']['key']);
143146

144147
$fromArray = CloudMessage::new()->withData($data);
145148
$serializedFromArray = Json::decode(Json::encode($fromArray), true);
149+
150+
$this->assertArrayHasKey('data', $serializedFromArray);
151+
$this->assertArrayHasKey('key', $serializedFromArray['data']);
146152
$this->assertSame('value', $serializedFromArray['data']['key']);
147153

148154
$this->assertSame($serializedFromObject, $serializedFromArray);

tests/Unit/Messaging/Processor/SetApnsContentAvailableIfNeededTest.php

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -37,6 +37,9 @@ public function itSetsTheExpectedPushType(array $messageData): void
3737

3838
$processed = Json::decode(Json::encode(($this->processor)($message)), true);
3939

40+
$this->assertArrayHasKey('apns', $processed);
41+
$this->assertArrayHasKey('payload', $processed['apns']);
42+
$this->assertArrayHasKey('aps', $processed['apns']['payload']);
4043
$this->assertArrayHasKey('content-available', $processed['apns']['payload']['aps']);
4144
$this->assertSame(1, $processed['apns']['payload']['aps']['content-available']);
4245
}

tests/Unit/Messaging/Processor/SetApnsPushTypeIfNeededTest.php

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -36,6 +36,8 @@ public function itSetsTheExpectedPushType(string $expected, array $messageData):
3636

3737
$processed = Json::decode(Json::encode(($this->processor)($message)), true);
3838

39+
$this->assertArrayHasKey('apns', $processed);
40+
$this->assertArrayHasKey('headers', $processed['apns']);
3941
$this->assertArrayHasKey('apns-push-type', $processed['apns']['headers']);
4042
$this->assertSame($expected, $processed['apns']['headers']['apns-push-type']);
4143
}

0 commit comments

Comments
 (0)