Pass service account file directly to the factory

jeromegamez · jeromegamez · commit 323203af85a4 · 2019-09-14T00:53:59.000+02:00
diff --git a/src/ServiceProvider.php b/src/ServiceProvider.php
@@ -33,8 +33,7 @@ private function registerComponents()
             $config = $app->make('config')['firebase'];
 
             if ($credentialsFile = $config['credentials']['file'] ?? null) {
-                $serviceAccount = Firebase\ServiceAccount::fromJsonFile((string) $credentialsFile);
-                $factory = $factory->withServiceAccount($serviceAccount);
+                $factory = $factory->withServiceAccount((string) $credentialsFile);
             }
 
             $enableAutoDiscovery = $config['credentials']['auto_discovery'] ?? true;

Original file line number	Diff line number	Diff line change
`@@ -33,8 +33,7 @@ private function registerComponents()`
`33`	`33`	`$config = $app->make('config')['firebase'];`
`34`	`34`
`35`	`35`	`if ($credentialsFile = $config['credentials']['file'] ?? null) {`
`36`		`- $serviceAccount = Firebase\ServiceAccount::fromJsonFile((string) $credentialsFile);`
`37`		`- $factory = $factory->withServiceAccount($serviceAccount);`
	`36`	`+ $factory = $factory->withServiceAccount((string) $credentialsFile);`
`38`	`37`	`}`
`39`	`38`
`40`	`39`	`$enableAutoDiscovery = $config['credentials']['auto_discovery'] ?? true;`