Skip to content

Commit 43ec3b2

Browse files
committed
Revert making the Service Provider deferred
I misinterpreted the sentence "If your provider is **only** registering binding in the service container. Apparently, aliases don't count as bindings.
1 parent b592e55 commit 43ec3b2

File tree

2 files changed

+4
-17
lines changed

2 files changed

+4
-17
lines changed

CHANGELOG.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,9 @@
22

33
## Unreleased
44

5+
* Revert making the Service provider deferrable. The auto discovery problem is hopefully still fixed because of
6+
the change in the latest version of the SDK.
7+
58
## 5.9.0 - 2024-06-23
69

710
* Service Provider Registration is now deferred. This should fix the credentials auto discovery in Laravel's

src/ServiceProvider.php

Lines changed: 1 addition & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,9 @@
55
namespace Kreait\Laravel\Firebase;
66

77
use Illuminate\Contracts\Container\Container;
8-
use Illuminate\Contracts\Support\DeferrableProvider;
98
use Kreait\Firebase;
109

11-
final class ServiceProvider extends \Illuminate\Support\ServiceProvider implements DeferrableProvider
10+
final class ServiceProvider extends \Illuminate\Support\ServiceProvider
1211
{
1312
public function boot(): void
1413
{
@@ -63,19 +62,4 @@ private function registerManager(): void
6362
$this->app->singleton(FirebaseProjectManager::class, static fn (Container $app) => new FirebaseProjectManager($app));
6463
$this->app->alias(FirebaseProjectManager::class, 'firebase.manager');
6564
}
66-
67-
public function provides(): array
68-
{
69-
return [
70-
Firebase\Contract\AppCheck::class,
71-
Firebase\Contract\Auth::class,
72-
Firebase\Contract\Database::class,
73-
Firebase\Contract\DynamicLinks::class,
74-
Firebase\Contract\Firestore::class,
75-
Firebase\Contract\Messaging::class,
76-
Firebase\Contract\RemoteConfig::class,
77-
Firebase\Contract\Storage::class,
78-
FirebaseProjectManager::class,
79-
];
80-
}
8165
}

0 commit comments

Comments
 (0)