Skip to content

Commit bd90a20

Browse files
committed
Add notice about not using the factory pattern.
1 parent 3a9bf0f commit bd90a20

File tree

2 files changed

+8
-0
lines changed

2 files changed

+8
-0
lines changed

CHANGELOG.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,10 @@
11
# CHANGELOG
22

3+
## Unreleased
4+
5+
* Added a notice about not using the factory pattern described in the SDK documentation when using this package.
6+
(Although not a code change, adding it in the changelog to enhance visibility)
7+
38
## 1.2.0 - 2019-10-26
49

510
* Updated `kreait/firebase-php` to `^4.35.0`

README.md

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -78,6 +78,9 @@ php artisan vendor:publish --provider="Kreait\Laravel\Firebase\ServiceProvider"
7878
Once you have retrieved a component, please refer to the [documentation of the Firebase PHP Admin SDK](https://firebase-php.readthedocs.io)
7979
for further information on how to use it.
8080

81+
**You don't need and should not use the `new Factory()` pattern described in the SDK documentation, this is already
82+
done for you with the Laravel Service Provider. Use Dependency Injection, the Facades or the `app()` helper instead**
83+
8184
## License
8285

8386
The MIT License (MIT). Please see [License File](LICENSE) for more information.

0 commit comments

Comments
 (0)