Skip to content

Commit 646354d

Browse files
committed
fix(ci): package node linux binding and sanitize go flags
1 parent 502ddfa commit 646354d

File tree

2 files changed

+4
-1
lines changed

2 files changed

+4
-1
lines changed

.github/workflows/ci-go.yaml

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,8 +86,11 @@ jobs:
8686
}
8787
$env:PATH = "$binPath;$ffiPath;$env:PATH"
8888
$env:LIB = "$ffiPath;$env:LIB"
89+
Remove-Item Env:CFLAGS -ErrorAction SilentlyContinue
90+
Remove-Item Env:CL -ErrorAction SilentlyContinue
8991
$env:CGO_LDFLAGS = "-L$ffiPath -lkreuzberg_ffi"
9092
$env:CGO_CFLAGS = "-I$workspace/crates/kreuzberg-ffi"
93+
$env:CGO_CXXFLAGS = $env:CGO_CFLAGS
9194
$env:CC = "cl.exe"
9295
$env:CXX = "cl.exe"
9396
} else {

.github/workflows/ci-node.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,7 @@ jobs:
8585
set -euo pipefail
8686
pnpm install
8787
pnpm exec napi build --platform --release --target ${{ matrix.target }}
88+
pnpm exec napi prepublish -t npm --no-gh-release
8889
mkdir -p artifacts
8990
# Collect artifacts from napi (if produced) and fallback to build outputs.
9091
pnpm exec napi artifacts --output-dir ./artifacts || true
@@ -101,7 +102,6 @@ jobs:
101102
cp "$f" "$dest"
102103
fi
103104
done
104-
pnpm exec napi prepublish -t npm --no-gh-release
105105
pnpm pack
106106
107107
- name: Upload Node bindings

0 commit comments

Comments
 (0)