Added ability to pass attributes to individual options in select/choices (#594)

* Added option_attributes to select element
* Added test for option attributes

Author: imTigger

src/Kris/LaravelFormBuilder/Fields/ChoiceType.php

@@ -107,7 +107,7 @@ protected function buildCheckableChildren($fieldType)
             $options = $this->formHelper->mergeOptions(
                 $this->getOption('choice_options'),
                 [
-                    'attr'       => ['id' => $id],
+                    'attr'       => array_merge(['id' => $id], $this->options['option_attributes'][$key] ?? []),
                     'label_attr' => ['for' => $id],
                     'label'      => $choice,
                     'checked'    => in_array($key, (array)$this->options[$this->valueProperty]),

src/Kris/LaravelFormBuilder/Fields/SelectType.php

@@ -27,6 +27,7 @@ public function getDefaults()
     {
         return [
             'choices' => [],
+            'option_attributes' => [],
             'empty_value' => null,
             'selected' => null
         ];

src/views/select.php

@@ -10,7 +10,7 @@
 
 <?php if ($showField): ?>
     <?php $emptyVal = $options['empty_value'] ? ['' => $options['empty_value']] : null; ?>
-    <?= Form::select($name, (array)$emptyVal + $options['choices'], $options['selected'], $options['attr']) ?>
+    <?= Form::select($name, (array)$emptyVal + $options['choices'], $options['selected'], $options['attr'], $options['option_attributes']) ?>
     <?php include helpBlockPath(); ?>
 <?php endif; ?>
 

tests/Fields/SelectTypeTest.php

@@ -39,11 +39,12 @@ public function it_creates_select_field(): void
         $expectedOptions['choices'] = $choices;
         $expectedOptions['empty_value'] = 'Select your sex';
         $expectedOptions['selected'] = '1';
+        $expectedOptions['option_attributes'] = [];
 
         $select = new SelectType('sex', 'select', $this->plainForm, $options);
 
         $select->render(['selected' => '1']);
 
         $this->assertEquals($expectedOptions, $select->getOptions());
     }
-}
+}

tests/FormTest.php

@@ -1178,4 +1178,55 @@ public function it_filter_and_mutate_fields_request_values()
         $this->assertEquals('TEST', $this->request['test_field']);
     }
 
+    /** @test */
+    public function it_add_option_attributes_properly()
+    {
+        $config = $this->config;
+
+        $formHelper = new FormHelper($this->view, $this->translator, $config);
+        $formBuilder = new FormBuilder($this->app, $formHelper, $this->eventDispatcher);
+
+        $choices = ['en' => 'English', 'fr' => 'French', 'zh' => 'Chinese'];
+        $optionAttributes = ['zh' => ['disabled' => 'disabled']];
+
+        $form = $formBuilder->plain()
+            ->add('languages_select', 'select', [
+                'choices' => $choices,
+                'option_attributes' => $optionAttributes
+            ])
+            ->add('languages_choice_select', 'choice', [
+                'choices' => $choices,
+                'option_attributes' => $optionAttributes,
+                'expanded' => false,
+                'multiple' => false
+            ])
+            ->add('languages_choice_select_multiple', 'choice', [
+                'choices' => $choices,
+                'option_attributes' => $optionAttributes,
+                'expanded' => false,
+                'multiple' => true
+            ])
+            ->add('languages_choice_checkbox', 'choice', [
+                'choices' => $choices,
+                'option_attributes' => $optionAttributes,
+                'expanded' => true,
+                'multiple' => true
+            ])
+            ->add('languages_choice_radio', 'choice', [
+                'choices' => $choices,
+                'option_attributes' => $optionAttributes,
+                'expanded' => true,
+                'multiple' => false
+            ]);
+
+        $formView = $form->renderForm();
+
+        $this->assertStringContainsString('<option value="zh" disabled="disabled">', $formView);
+        $this->assertStringNotContainsString('<option value="en" disabled="disabled">', $formView);
+        $this->assertStringNotContainsString('<option value="fr" disabled="disabled">', $formView);
+        $this->assertStringContainsString('<input id="languages_choice_checkbox_zh" disabled="disabled" name="languages_choice_checkbox[]" type="checkbox" value="zh">', $formView);
+        $this->assertStringNotContainsString('<input id="languages_choice_checkbox_en" disabled="disabled" name="languages_choice_checkbox[]" type="checkbox" value="en">', $formView);
+        $this->assertStringContainsString('<input id="languages_choice_radio_zh" disabled="disabled" name="languages_choice_radio" type="radio" value="zh">', $formView);
+        $this->assertStringNotContainsString('<input id="languages_choice_radio_en" disabled="disabled" name="languages_choice_radio" type="radio" value="en">', $formView);
+    }
 }