fix(scenarios): fix network_chaos_ng variable shadowing and instance_count condition

Signed-off-by: NETIZEN-11 <niteshkumar121411@gmail.com>

Author: NETIZEN-11

krkn/scenario_plugins/network_chaos_ng/models.py

@@ -56,6 +56,10 @@ def validate(self) -> list[str]:
             errors.append("wait_duration must be an int")
         if not isinstance(self.test_duration, int):
             errors.append("test_duration must be an int")
+        if not isinstance(self.instance_count, int):
+            errors.append("instance_count must be an int")
+        elif self.instance_count < 0:
+            errors.append("instance_count must be >= 0")
         return errors
 
 

krkn/scenario_plugins/network_chaos_ng/network_chaos_ng_scenario_plugin.py

@@ -1,3 +1,5 @@
+#!/usr/bin/env python
+#
 # Copyright 2025 The Krkn Authors
 #
 # Licensed under the Apache License, Version 2.0 (the "License");
@@ -11,6 +13,7 @@
 # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 # See the License for the specific language governing permissions and
 # limitations under the License.
+
 import logging
 import queue
 import random
@@ -65,8 +68,8 @@ def run(
                         )
 
                     if (
-                        network_chaos_config.instance_count != 0
-                        and network_chaos_config.instance_count < len(targets)
+                        network_chaos_config.instance_count > 0
+                        and len(targets) > network_chaos_config.instance_count
                     ):
                         targets = random.sample(
                             targets, network_chaos_config.instance_count
@@ -76,7 +79,7 @@ def run(
                         self.run_parallel(targets, network_chaos)
                     else:
                         self.run_serial(targets, network_chaos)
-                    if len(config) > 1:
+                    if len(scenario_config) > 1:
                         logging.info(
                             f"waiting {network_chaos_config.wait_duration} seconds before running the next "
                             f"Network Chaos NG Module"