backend for generating and adding occlusion notes

* implemented proto
- getting image data with path
- returning bytes, file name and current deck id to frontend
- frontend return generated occlusion and notes to backend

* Created image occlusion dialog to serve image-occlusion
* Added image occlusion in editor toolbar to open image occlusion page
*

Author: krmanik

ftl/core/editing.ftl

@@ -68,3 +68,5 @@ editing-close-html-tags = Auto-close HTML tags
 ## You don't need to translate these strings, as they will be replaced with different ones soon.
 
 editing-html-editor = HTML Editor
+
+editing-image-occlusion = Image Occlusion

ftl/core/notetypes.ftl

@@ -35,3 +35,9 @@ notetypes-note-types = Note Types
 notetypes-options = Options
 notetypes-please-add-another-note-type-first = Please add another note type first.
 notetypes-type = Type
+
+## Image Occlusion
+
+notetypes-occlusions-field = Occlusions
+notetypes-image-field = Image
+notetypes-notes-field = Notes

proto/anki/backend.proto

@@ -31,6 +31,7 @@ enum ServiceIndex {
   SERVICE_INDEX_LINKS = 15;
   SERVICE_INDEX_IMPORT_EXPORT = 16;
   SERVICE_INDEX_ANKIDROID = 17;
+  SERVICE_INDEX_IMAGE_OCCLUSION = 18;
 }
 
 message BackendInit {

proto/anki/image_occlusion.proto

@@ -0,0 +1,37 @@
+// Copyright: Ankitects Pty Ltd and contributors
+// License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
+
+syntax = "proto3";
+
+option java_multiple_files = true;
+
+package anki.image_occlusion;
+
+import "anki/cards.proto";
+import "anki/collection.proto";
+import "anki/notes.proto";
+import "anki/generic.proto";
+
+service ImageOcclusionService {
+  rpc GetImageClozeMetadata(ImageClozeMetadataRequest) returns (ImageClozeMetadata);
+  rpc AddImageOcclusionNotes(AddImageOcclusionNotesRequest) returns (collection.OpChanges);
+}
+
+message ImageClozeMetadataRequest {
+  string path = 1;
+}
+
+message ImageClozeMetadata {
+  bytes data = 1;
+  string name = 2;
+  int64 deck_id = 3;
+}
+
+message AddImageOcclusionNotesRequest {
+  string image_path = 1;
+  int64 deck_id = 2;
+  string occlusions = 3;
+  string header = 4;
+  string notes = 5;
+  repeated string tags = 6;
+}

pylib/anki/collection.py

@@ -11,6 +11,7 @@
     config_pb2,
     generic_pb2,
     import_export_pb2,
+    image_occlusion_pb2,
     links_pb2,
     search_pb2,
     stats_pb2,
@@ -38,6 +39,8 @@
 CsvMetadata = import_export_pb2.CsvMetadata
 DupeResolution = CsvMetadata.DupeResolution
 Delimiter = import_export_pb2.CsvMetadata.Delimiter
+ImageClozeMetadata = image_occlusion_pb2.ImageClozeMetadata
+AddImageOcclusionNotesRequest = image_occlusion_pb2.AddImageOcclusionNotesRequest
 
 import copy
 import os
@@ -454,6 +457,32 @@ def import_json_file(self, path: str) -> ImportLogWithChanges:
     def import_json_string(self, json: str) -> ImportLogWithChanges:
         return self._backend.import_json_string(json)
 
+    # Image Occlusion
+    def get_image_cloze_metadata(self, path: str | None) -> ImageClozeMetadata:
+        request = image_occlusion_pb2.ImageClozeMetadataRequest(path=path)
+        return self._backend.get_image_cloze_metadata(request)
+
+    def add_image_occlusion_notes(
+        self, 
+        image_path: str | None, 
+        deck_id: int | None, 
+        notes_data: bytes | None,
+        occlusions: str | None,
+        header: str | None,
+        notes: str | None,
+        tags: list[str] | None
+    ) -> bool:
+        request = image_occlusion_pb2.AddImageOcclusionNotesRequest(
+            image_path=image_path, 
+            deck_id=deck_id, 
+            notes_data=notes_data,
+            occlusions=occlusions,
+            header=header,
+            notes=notes,
+            tags=tags
+        )
+        return self._backend.add_image_occlusion_notes(request)
+
     # Object helpers
     ##########################################################################
 

pylib/tools/genbackend.py

@@ -20,6 +20,7 @@
 import anki.decks_pb2
 import anki.i18n_pb2
 import anki.import_export_pb2
+import anki.image_occlusion_pb2
 import anki.links_pb2
 import anki.media_pb2
 import anki.notes_pb2
@@ -187,6 +188,7 @@ def render_service(
     MEDIA=anki.media_pb2,
     LINKS=anki.links_pb2,
     IMPORT_EXPORT=anki.import_export_pb2,
+    IMAGE_OCCLUSION=anki.image_occlusion_pb2,
 )
 
 for service in anki.backend_pb2.ServiceIndex.DESCRIPTOR.values:
@@ -238,6 +240,7 @@ def render_service(
 import anki.tags_pb2
 import anki.media_pb2
 import anki.import_export_pb2
+import anki.image_occlusion_pb2
 
 class RustBackendGenerated:
     def _run_command(self, service: int, method: int, input: Any) -> bytes:

qt/aqt/editor.py

@@ -56,6 +56,7 @@
     tr,
 )
 from aqt.webview import AnkiWebView
+from aqt.imageocclusion import ImageOcclusionDialog
 
 pics = ("jpg", "jpeg", "png", "tif", "tiff", "gif", "svg", "webp", "ico")
 audio = (
@@ -1171,6 +1172,27 @@ def collapseTags(self) -> None:
     def expandTags(self) -> None:
         aqt.mw.pm.set_tags_collapsed(self.editorMode, False)
 
+    def onImageOcclusion(self) -> None:
+        """Show a file selection screen, then get selected image path."""
+        extension_filter = " ".join(
+            f"*.{extension}" for extension in sorted(itertools.chain(pics))
+        )
+        filter = f"{tr.editing_media()} ({extension_filter})"
+
+        def accept(file: str) -> None:
+            diag = ImageOcclusionDialog(self.mw, file)
+
+
+        file = getFile(
+            parent=self.widget,
+            title=tr.editing_add_media(),
+            cb=cast(Callable[[Any], None], accept),
+            filter=filter,
+            key="media",
+        )
+
+        self.parentWindow.activateWindow()
+
     # Links from HTML
     ######################################################################
 
@@ -1202,6 +1224,7 @@ def _init_links(self) -> None:
             toggleCloseHTMLTags=Editor.toggleCloseHTMLTags,
             expandTags=Editor.expandTags,
             collapseTags=Editor.collapseTags,
+            imageOcclusion=Editor.onImageOcclusion,
         )
 
 

qt/aqt/imageocclusion.py

@@ -0,0 +1,53 @@
+# Copyright: Ankitects Pty Ltd and contributors
+# License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
+
+from __future__ import annotations
+
+import aqt
+import aqt.deckconf
+import aqt.main
+import aqt.operations
+from aqt.qt import *
+from aqt.utils import addCloseShortcut, disable_help_button, restoreGeom, saveGeom, tr
+from aqt.webview import AnkiWebView
+
+
+class ImageOcclusionDialog(QDialog):
+
+    TITLE = "image occlusion"
+    silentlyClose = True
+
+    def __init__(
+        self,
+        mw: aqt.main.AnkiQt,
+        path: str,
+    ) -> None:
+        QDialog.__init__(self, mw)
+        self.mw = mw
+        self._setup_ui(path)
+        self.show()
+
+    def _setup_ui(self, path: str) -> None:
+        self.setWindowModality(Qt.WindowModality.ApplicationModal)
+        self.mw.garbage_collect_on_dialog_finish(self)
+        self.setMinimumSize(400, 300)
+        disable_help_button(self)
+        restoreGeom(self, self.TITLE)
+        addCloseShortcut(self)
+
+        self.web = AnkiWebView(title=self.TITLE)
+        self.web.setVisible(False)
+        self.web.load_ts_page("image-occlusion")
+        layout = QVBoxLayout()
+        layout.setContentsMargins(0, 0, 0, 0)
+        layout.addWidget(self.web)
+        self.setLayout(layout)
+
+        self.web.eval(f"anki.setupImageOcclusion('{path}');")
+        self.setWindowTitle(self.TITLE)
+
+    def reject(self) -> None:
+        self.web.cleanup()
+        self.web = None
+        saveGeom(self, self.TITLE)
+        QDialog.reject(self)

qt/aqt/mediasrv.py

@@ -447,6 +447,17 @@ def handle_on_main() -> None:
     return b""
 
 
+def image_occlusion() -> bytes:
+    data = request.data
+
+    def handle_on_main() -> None:
+        window = aqt.mw.app.activeWindow()
+        if isinstance(window, ImageOcclusionDialog):
+            window.do_image_occlusion(data)
+
+    aqt.mw.taskman.run_on_main(handle_on_main)
+    return b""
+
 post_handler_list = [
     congrats_info,
     get_deck_configs_for_update,
@@ -455,6 +466,7 @@ def handle_on_main() -> None:
     set_scheduling_states,
     change_notetype,
     import_csv,
+    image_occlusion,
 ]
 
 
@@ -478,6 +490,9 @@ def handle_on_main() -> None:
     "set_graph_preferences",
     # TagsService
     "complete_tag",
+    # ImageOcclusionService
+    "get_image_cloze_metadata",
+    "add_image_occlusion_notes"
 ]
 
 

rslib/src/backend/image_occlusion.rs

@@ -0,0 +1,35 @@
+// Copyright: Ankitects Pty Ltd and contributors
+// License: GNU AGPL, version 3 or later; http://www.gnu.org/licenses/agpl.html
+
+use super::Backend;
+pub(super) use crate::pb::image_occlusion::imageocclusion_service::Service as ImageOcclusionService;
+use crate::{
+    pb::{self as pb},
+    prelude::*,
+};
+
+impl ImageOcclusionService for Backend {
+    fn get_image_cloze_metadata(
+        &self,
+        input: pb::image_occlusion::ImageClozeMetadataRequest,
+    ) -> Result<pb::image_occlusion::ImageClozeMetadata> {
+        self.with_col(|col| col.get_image_cloze_metadata(&input.path))
+    }
+
+    fn add_image_occlusion_notes(
+        &self,
+        input: pb::image_occlusion::AddImageOcclusionNotesRequest,
+    ) -> Result<pb::collection::OpChanges> {
+        self.with_col(|col| {
+            col.add_image_occlusion_notes(
+                &input.image_path,
+                input.deck_id.into(),
+                &input.occlusions,
+                &input.header,
+                &input.notes,
+                input.tags,
+            )
+        })
+        .map(Into::into)
+    }
+}