ci: default back to -mod=mod in CI

Author: krmcbride

.github/workflows/ci.yml

@@ -46,6 +46,9 @@ jobs:
           go-version-file: "go.mod"
           cache: true
 
+      - name: Install dependencies
+        run: go mod download
+
       - name: Check code formatting
         run: make format-ci
 
@@ -71,6 +74,9 @@ jobs:
           go-version-file: "go.mod"
           cache: true
 
+      - name: Install dependencies
+        run: go mod download
+
       - name: Build for ${{ matrix.os }}/${{ matrix.arch }}
         run: |
           GOOS=${{ matrix.os }} GOARCH=${{ matrix.arch }} make build-ci

Makefile

@@ -128,8 +128,8 @@ build: ## Build the agent
 
 .PHONY: test-ci
 test-ci: ## Run tests in CI
-	go test -coverprofile=coverage.out ./...
-	go tool cover -func=coverage.out
+	GOFLAGS="" go test -coverprofile=coverage.out ./...
+	GOFLAGS="" go tool cover -func=coverage.out
 
 .PHONY: format-ci
 format-ci: install-gofumpt install-goimports-reviser ## Check code formatting in CI
@@ -150,8 +150,10 @@ format-ci: install-gofumpt install-goimports-reviser ## Check code formatting in
 	@echo "All files are properly formatted!"
 
 .PHONY: lint-ci
-lint-ci: lint ## Run linters in CI (same as lint)
+lint-ci: install-golangci-lint ## Run linters in CI
+	GOFLAGS="" $(GOLANGCI_LINT) run
 
 .PHONY: build-ci
-build-ci: build ## Build the MCP server in CI
+build-ci: ## Build the MCP server in CI
+	GOFLAGS="" CGO_ENABLED=0 GOOS=$(GOOS) GOARCH=$(GOARCH) go build -o dist/server cmd/server/main.go
 

docs/ci-best-practices.md

@@ -65,13 +65,14 @@ strategy:
 
 **Integration with Makefile:**
 
-- `make test-ci`: Runs tests with coverage output
+- `make test-ci`: Runs tests with coverage output (overrides vendor mode)
 - `make format-ci`: Checks formatting without modifying files
-- `make lint-ci`: Runs linters (delegates to `make lint`)
-- `make build-ci`: Cross-platform build validation
+- `make lint-ci`: Runs linters (overrides vendor mode)
+- `make build-ci`: Cross-platform build validation (overrides vendor mode)
 
 **Environment Variables:**
 
 - `GOOS` and `GOARCH`: Set by matrix for cross-compilation
-- `GOFLAGS="-mod=vendor"`: Automatically set via Makefile export
+- `GOFLAGS=""`: CI targets override vendor mode to leverage Go module cache
+- Local development still uses `GOFLAGS="-mod=vendor"` for offline builds