Skip to content

Commit 235669d

Browse files
committed
Remove ghcjs builder. Update README
1 parent 62198ba commit 235669d

File tree

4 files changed

+11
-276
lines changed

4 files changed

+11
-276
lines changed

README.md

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,8 +3,15 @@
33
This is a fork that builds only Cabal projects, uses ghc from upstream
44
nixpkgs, and doesn't support cross platform builds / ghcjs builds. It
55
was forked after we had to build every ghc from 8.10.7 to 9.8.2 one
6-
too many times. This fork also contains a fix that properly respects
7-
index-state in presence of revisions
6+
too many times. This fork also contains a bug fix that properly
7+
respects index-state in presence of revisions.
8+
9+
There is a bug that is carried on from haskell.nix repo, where pinning
10+
a different version of a ghc core library will silently fail i.e. the
11+
plan succeeds but it'll always use the library shipped with the ghc
12+
version which can be misleading.
13+
14+
815

916
`haskell.nix` can automatically translate your Cabal or Stack project and
1017
its dependencies into Nix code.

builder/Setup.ghcjs.hs

Lines changed: 0 additions & 272 deletions
This file was deleted.

builder/hspkg-builder.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ let
3131

3232
cabalFile = if package-description-override == null || bundledSrc != null then null else package-description-override;
3333

34-
defaultSetupSrc = if stdenv.hostPlatform.isGhcjs then ./Setup.ghcjs.hs else ./Setup.hs;
34+
defaultSetupSrc = if stdenv.hostPlatform.isGhcjs then abort "No implementation for ghcjs" else ./Setup.hs;
3535

3636
setup = if package.buildType == "Simple"
3737
then

overlays/default-setup.nix

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ let
1313
haskellLib = final.haskell-nix.haskellLib;
1414
defaultSetupSrc =
1515
if final.stdenv.targetPlatform.isGhcjs
16-
then ../builder/Setup.ghcjs.hs
16+
then abort "No implementation for ghcjs"
1717
else ../builder/Setup.hs;
1818
addDefaultSetup = compiler-nix-name: ghc:
1919
let

0 commit comments

Comments
 (0)