Allow bool flag to don't have value

Alexis Destrez · Alexis Destrez · commit 0b885292da8f · 2024-02-28T17:59:25.000+01:00
diff --git a/mapper/spf13/cobra/flag.go b/mapper/spf13/cobra/flag.go
@@ -8,7 +8,10 @@ import (
 
 func setCobraFlagsFromCLIFlags(set *pflag.FlagSet, flags []cli.Flag) {
 	for _, flag := range flags {
-		set.VarP(&flagValuer{flag}, flag.LongName(), flag.ShortName(), flag.Description())
+		fset := set.VarPF(&flagValuer{flag}, flag.LongName(), flag.ShortName(), flag.Description())
+		if _, isBool := flag.Destination().(*bool); isBool {
+			fset.NoOptDefVal = "true"
+		}
 	}
 }
 

Original file line number	Diff line number	Diff line change
`@@ -8,7 +8,10 @@ import (`
`8`	`8`
`9`	`9`	`func setCobraFlagsFromCLIFlags(set *pflag.FlagSet, flags []cli.Flag) {`
`10`	`10`	`for _, flag := range flags {`
`11`		`- set.VarP(&flagValuer{flag}, flag.LongName(), flag.ShortName(), flag.Description())`
	`11`	`+ fset := set.VarPF(&flagValuer{flag}, flag.LongName(), flag.ShortName(), flag.Description())`
	`12`	`+ if _, isBool := flag.Destination().(*bool); isBool {`
	`13`	`+ fset.NoOptDefVal = "true"`
	`14`	`+ }`
`12`	`15`	`}`
`13`	`16`	`}`
`14`	`17`