Skip to content

This PR needs attention: Refactor code, better documentation and build script #4

@krshrimali

Description

@krshrimali

I appreciate the attention given to this project, and I thank all of you for that. Keeping that in mind, I've decided to give this work another look. A few notes:

  • This code was ported to OpenCV's contrib repository (quality module: https://docs.opencv.org/4.5.2/d8/d99/classcv_1_1quality_1_1QualityBRISQUE.html).
  • This repo uses incorrect models which might result in wrong results, this was however corrected while porting to OpenCV.
  • I wrote this code when I was in my 2nd year of Bachelors's, pretty young! ;) I've loved C++ more with time, and I plan to write better code for this.

So, what's the plan?

  • Use models appropriate for this code. Create a link in case the models are deleted from the source (will have to check if it's allowed or not though).
  • Refactor code for both C++ and Python.
  • Re-visit dependency of LIBSVM for this project.
  • Build scripts for the C++ code. (Cross-platform)
  • Better documentation on how to use, and known issues (if any).
  • Address all the opened issues on this project.

This project has come back to life, thanks to all of you!

How to contribute?

In case you are planning to contribute, please reach out here and let me know what's your plan (if you have one already), and what task you want to pick up. I'll create separate issues for the tasks above later, but for now, please feel free to comment here.

Thanks!
~ Kushashwa (/krshrimali/Kush)

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or requesthelp wantedExtra attention is needed

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions