Skip to content

Conversation

@shreyabiradar07
Copy link
Contributor

@shreyabiradar07 shreyabiradar07 commented Feb 10, 2026

Description

Updated the filterbuilder logic to use double quotes for empty string comparisons

Fixes #1788

Type of change

  • Bug fix
  • New feature
  • Docs update
  • Breaking change (What changes might users need to make in their application due to this PR?)
  • Requires DB changes

How has this been tested?

Please describe the tests that were run to verify your changes and steps to reproduce. Please specify any test configuration required.

  • New Test X
  • Functional testsuite

Test Configuration

  • Kubernetes clusters tested on:

Checklist 🎯

  • Followed coding guidelines
  • Comments added
  • Dependent changes merged
  • Documentation updated
  • Tests added or updated

Additional information

Include any additional information such as links, test results, screenshots here

Summary by Sourcery

Bug Fixes:

  • Correct empty-string filter expression to use double quotes instead of single quotes in dynamically constructed queries.

Signed-off-by: Shreya Biradar <shbirada@ibm.com>
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Feb 10, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Adjusts the query filter builder to use double quotes instead of single quotes when constructing non-empty string comparisons for metadata filters.

File-Level Changes

Change Details Files
Update empty-string comparison in dynamic filter construction to use double quotes to match expected query syntax.
  • Change the constructed filter expression from using single quotes around an empty string to using double quotes
  • Keep include and exclude regex handling logic unchanged while aligning the empty-string comparison syntax with the rest of the query format
src/main/java/com/autotune/common/datasource/DataSourceMetadataOperator.java

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@shreyabiradar07 shreyabiradar07 self-assigned this Feb 10, 2026
@shreyabiradar07 shreyabiradar07 added bug Something isn't working local_monitoring labels Feb 10, 2026
@shreyabiradar07 shreyabiradar07 moved this to In Progress in Monitoring Feb 10, 2026
@shreyabiradar07 shreyabiradar07 added this to the Kruize 0.9 Release milestone Feb 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working local_monitoring

Projects

Status: In Progress

Development

Successfully merging this pull request may close these issues.

1 participant