kueue-tests #4
Closed
kueue-tests #4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kryanbeane
force-pushed
the
kueue-integration
branch
6 times, most recently
from
a71cd5b to
2c5937b
Compare
kryanbeane
commented
Sep 11, 2025
Comment on lines
-98
to
-148
| self.verify_cluster_cleanup(rayjob) | ||
|
|
||
| def _wait_for_job_status( | ||
| self, | ||
| rayjob: RayJob, | ||
| expected_status: str, | ||
| timeout: int = 30, | ||
| ) -> bool: | ||
| """Wait for a job to reach a specific deployment status.""" | ||
| elapsed_time = 0 | ||
| check_interval = 2 | ||
|
|
||
| while elapsed_time < timeout: | ||
| status = self.job_api.get_job_status( | ||
| name=rayjob.name, k8s_namespace=rayjob.namespace | ||
| ) | ||
| if status and status.get("jobDeploymentStatus") == expected_status: | ||
| return True | ||
|
|
||
| sleep(check_interval) | ||
| elapsed_time += check_interval | ||
|
|
||
| return False | ||
|
|
||
| def verify_cluster_cleanup(self, rayjob: RayJob, timeout: int = 60): | ||
| """Verify that the cluster created by the RayJob has been cleaned up.""" | ||
| elapsed_time = 0 | ||
| check_interval = 5 | ||
| cluster_api = RayClusterApi() | ||
|
|
||
| while elapsed_time < timeout: | ||
| try: | ||
| cluster_info = cluster_api.get_ray_cluster( | ||
| name=rayjob.cluster_name, k8s_namespace=rayjob.namespace | ||
| ) | ||
| # Cluster doesn't exist | ||
| if cluster_info is None: | ||
| return | ||
|
|
||
| sleep(check_interval) | ||
| elapsed_time += check_interval | ||
|
|
||
| except kubernetes.client.rest.ApiException as e: | ||
| if e.status == 404: | ||
| return | ||
| else: | ||
| raise e | ||
|
|
||
| raise TimeoutError( | ||
| f"Cluster '{rayjob.cluster_name}' was not cleaned up within {timeout} seconds" | ||
| ) |
Owner
Author
There was a problem hiding this comment.
Moved to support.py so they can be reused
kryanbeane
force-pushed
the
kueue-integration
branch
19 times, most recently
from
e62b274 to
7398069
Compare
kryanbeane
force-pushed
the
kueue-integration
branch
4 times, most recently
from
344e935 to
274ba47
Compare
kryanbeane
force-pushed
the
kueue-integration
branch
19 times, most recently
from
b89e24d to
22f507d
Compare
kryanbeane
force-pushed
the
kueue-integration
branch
6 times, most recently
from
3f611b6 to
9a22414
Compare
kryanbeane
force-pushed
the
kueue-integration
branch
from
9a22414 to
efd1396
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.