save wallet file

[TechyGuy17]

Currently the wallet file never gets saved, so XKR sent to the api is lost on reboot

[Coffeboi]

Coffe is on the case

[f-r00t]

I believe it's an issue with the encryptWalletToString(). You should use toJSONString() instead.

See here:

hugin-api/utils/wallet.js

Line 90 in 126bede

encrypted_wallet = await wallet.encryptWalletToString('hugin')

[n9lsjr]

I do not think that is the issue, the problem seems to be that the wallet only saves one time (on startup)

I think you need a interval like this to save the wallet more often:
https://github.com/kryptokrona/yggdrasil-wallet/blob/149c335efd6e69ad2c8c307cbfa0fe80677cac7d/src/backend/electron.cjs#L306

Otherwise it will not remember anything that happens during the wallet is online and will thus reset on next startup

[f-r00t]

It saves every 60s.

First the saveWallet() function is called on startup:
https://github.com/kryptokrona/hugin-api/blob/main/server.js#L159

And as you can see here, the function then calls itself every 90s:

hugin-api/utils/wallet.js

Line 102 in 126bede

await sleep(90 * 1000)

So either that loop crashes, potentially because it gets "too recursive" i.e. is several thousand function calls in eventually, or there is something else wrong.

A better method would probaby be to have an interval that is started in server.js, something like:
setInterval(function() { saveWallet(); }, 60000);

[n9lsjr]

That is true lol, but in this recursive loop the variable walletExists is set to true after first save, then it will probably not save it again.

hugin-api/utils/wallet.js

Lines 97 to 99 in 126bede

	if (!walletExists) {
	log.info(getTimestamp() + ' INFO: Wallet does not exist. Creating and saving wallet to db...')
	await saveWalletToDb(encrypted_wallet, mnemonicSeed.toString())

[f-r00t]

Yeah that makes sense. After doing some research on sequalize, it seems like this is the general way of updating an entry:

// Change everyone without a last name to "Doe"
await User.update({ lastName: "Doe" }, {
  where: {
    lastName: null
  }
});

(https://sequelize.org/docs/v6/core-concepts/model-querying-basics/)

That probably would translate to something like this in our codebase:

await sequelize.transaction(async (t) => {
    return models.Wallet.update(
        { encrypted_wallet: newEncryptedStr }, 
        { where: {} } // Empty where clause updates all records, i.e. the only wallet record we have
    );
});