Possible retain cycle when using plugins ?

[paul1893]

Hello ✋

I played with the sample app and edit it a bit. I embed a STTextView in a new NSWindow that I can open from a first one. I've added NeonPlugin and STAnnotationPlugin to this STTextView.

After closing this window, STTextView is still in memory (through the Xcode memory graph). Which I don't have when I disable the plugins.

I suppose there is a retain cycle with plugin usage as STTextView hold a reference to STPlugin (through a Plugin). This Plugin gets a reference to a STPluginEvents too. But this STPluginEvents hold closures that reference STPluginCoordinatorContext (which directly contains STTextView) & also direclty STTextView in case of NeonPlugin and STAnnotationPlugin this create a retain cycle.
tearDown that stands in deinit of STTextView seems then to never being called for me to get a chance to break the retain cycle manually, so I quickly (and dirty) tried to add a viewWillMove(toWindow:) as a workaround in STTextView to call the tearDown manually and it indeed breaks the retain cycle and free up the memory after closing my window.

May be I'm not using the plugins as I should though 🤷‍♂️. Did you notice the same behavior too ?

[krzyzanowskim]

possible. if you happen to figure out some solution to that, don't hesitate to open PR