move notifier modules to internals

Author: ks6088ts

scripts/agent_operator.py

@@ -9,20 +9,13 @@
 from template_langgraph.agents.image_classifier_agent.models import Results
 from template_langgraph.agents.issue_formatter_agent.agent import graph as issue_formatter_agent_graph
 from template_langgraph.agents.kabuto_helpdesk_agent.agent import graph as kabuto_helpdesk_agent_graph
-from template_langgraph.agents.news_summarizer_agent.agent import MockNotifier, NewsSummarizerAgent
-from template_langgraph.agents.news_summarizer_agent.agent import (
-    graph as news_summarizer_agent_graph,
-)
+from template_langgraph.agents.news_summarizer_agent.agent import graph as news_summarizer_agent_graph
 from template_langgraph.agents.news_summarizer_agent.models import (
     AgentInputState,
     AgentState,
     Article,
 )
 from template_langgraph.agents.task_decomposer_agent.agent import graph as task_decomposer_agent_graph
-from template_langgraph.internals.scrapers import get_scraper
-from template_langgraph.internals.summarizers import (
-    get_summarizer,
-)
 from template_langgraph.loggers import get_logger
 
 # Initialize the Typer application
@@ -154,11 +147,7 @@ def news_summarizer_agent(
     if verbose:
         logger.setLevel(logging.DEBUG)
 
-    graph = NewsSummarizerAgent(
-        notifier=MockNotifier(),
-        scraper=get_scraper(),
-        summarizer=get_summarizer(),
-    ).create_graph()
+    graph = news_summarizer_agent_graph
     for event in graph.stream(
         input=AgentState(
             input=AgentInputState(

template_langgraph/agents/news_summarizer_agent/agent.py

@@ -8,40 +8,27 @@
     StructuredArticle,
     SummarizeWebContentState,
 )
-from template_langgraph.internals.scrapers import (
-    BaseScraper,
-    HttpxScraper,
-    MockScraper,
-)
-from template_langgraph.internals.summarizers import (
-    BaseSummarizer,
-    LlmSummarizer,
-    MockSummarizer,
-)
+from template_langgraph.internals.notifiers import get_notifier
+from template_langgraph.internals.scrapers import get_scraper
+from template_langgraph.internals.summarizers import get_summarizer
 from template_langgraph.llms.azure_openais import AzureOpenAiWrapper
 from template_langgraph.loggers import get_logger
 
 logger = get_logger(__name__)
 
 
-class MockNotifier:
-    def notify(self, id: str, body: dict) -> None:
-        """Simulate sending a notification to the user."""
-        logger.info(f"Notification sent for request {id}: {body}")
-
-
 class NewsSummarizerAgent:
     def __init__(
         self,
         llm=AzureOpenAiWrapper().chat_model,
-        notifier=MockNotifier(),
-        scraper: BaseScraper = MockScraper(),
-        summarizer: BaseSummarizer = MockSummarizer(),
+        notifier=get_notifier(),
+        scraper=get_scraper(),
+        summarizer=get_summarizer(),
     ):
         self.llm = llm
         self.notifier = notifier
-        self.scraper: BaseScraper = scraper
-        self.summarizer: BaseSummarizer = summarizer
+        self.scraper = scraper
+        self.summarizer = summarizer
 
     def create_graph(self):
         """Create the main graph for the agent."""
@@ -133,17 +120,13 @@ def notify(self, state: AgentState) -> AgentState:
         for i, article in enumerate(state.articles):
             summary[i] = article.model_dump()
         self.notifier.notify(
-            id=state.input.id,
-            body=summary,
+            text=summary.__str__(),
         )
         return state
 
 
-# For testing
-# graph = NewsSummarizerAgent().create_graph()
-
 graph = NewsSummarizerAgent(
-    notifier=MockNotifier(),
-    scraper=HttpxScraper(),
-    summarizer=LlmSummarizer(),
+    notifier=get_notifier(),
+    scraper=get_scraper(),
+    summarizer=get_summarizer(),
 ).create_graph()

template_langgraph/internals/notifiers.py

@@ -0,0 +1,69 @@
+"""Scraper interfaces and implementations for NewsSummarizerAgent.
+
+This module defines an abstract base scraper so different scraping strategies
+(mock, httpx-based, future headless browser, etc.) can be plugged into the agent
+without changing orchestration logic.
+"""
+
+from __future__ import annotations
+
+from abc import ABC, abstractmethod
+from enum import Enum
+from functools import lru_cache
+
+from pydantic_settings import BaseSettings, SettingsConfigDict
+
+from template_langgraph.loggers import get_logger
+
+logger = get_logger(__name__)
+
+
+class NotifierType(str, Enum):
+    MOCK = "mock"
+
+
+class Settings(BaseSettings):
+    notifier_type: NotifierType = NotifierType.MOCK
+
+    model_config = SettingsConfigDict(
+        env_file=".env",
+        env_ignore_empty=True,
+        extra="ignore",
+    )
+
+
+@lru_cache
+def get_notifier_settings() -> Settings:
+    """Get notifier settings."""
+    return Settings()
+
+
+class BaseNotifier(ABC):
+    """Abstract base notifier."""
+
+    @abstractmethod
+    def notify(self, text: str):
+        """Send a notification with the given text.
+
+        Args:
+            text: The text to include in the notification.
+
+        """
+        raise NotImplementedError
+
+
+class MockNotifier(BaseNotifier):
+    """Deterministic notifier for tests / offline development."""
+
+    def notify(self, text: str):
+        logger.info(f"Mock notify with text: {text}")
+
+
+def get_notifier(settings: Settings = None) -> BaseNotifier:
+    if settings is None:
+        settings = get_notifier_settings()
+
+    if settings.notifier_type == NotifierType.MOCK:
+        return MockNotifier()
+    else:
+        raise ValueError(f"Unknown notifier type: {settings.notifier_type}")