#39: Validate groups for proto3 (illegal)

Author: kshchepanovskyi

src/main/java/io/protostuff/jetbrains/plugin/annotator/ProtoErrorsAnnotator.java

@@ -15,6 +15,7 @@
 import io.protostuff.jetbrains.plugin.psi.EnumNode;
 import io.protostuff.jetbrains.plugin.psi.FieldLabel;
 import io.protostuff.jetbrains.plugin.psi.FieldNode;
+import io.protostuff.jetbrains.plugin.psi.GroupNode;
 import io.protostuff.jetbrains.plugin.psi.MessageField;
 import io.protostuff.jetbrains.plugin.psi.MessageNode;
 import io.protostuff.jetbrains.plugin.psi.OptionNode;
@@ -64,6 +65,8 @@ public void annotate(@NotNull PsiElement element, @NotNull AnnotationHolder hold
                     checkDuplicateFieldNames(fields);
                     checkReservedFieldTags(message, fields);
                     checkReservedFieldNames(message, fields);
+                } else if (element instanceof GroupNode) {
+                    checkGroupNodeDeprecated((GroupNode)element, syntax);
                 } else if (element instanceof FieldNode) {
                     FieldNode field = (FieldNode) element;
                     checkFieldLabel(field, syntax);
@@ -84,6 +87,14 @@ public void annotate(@NotNull PsiElement element, @NotNull AnnotationHolder hold
         }
     }
 
+    private void checkGroupNodeDeprecated(GroupNode element, Syntax syntax) {
+        if (syntax != Syntax.PROTO3) {
+            return;
+        }
+        String message = message("error.groups.not.supported");
+        markError(element.getNode(), null, message);
+    }
+
     private void checkDefaultValue(@NotNull OptionNode option, Syntax syntax) {
         if (syntax != Syntax.PROTO3) {
             return;

src/main/resources/io/protostuff/protobuf-jetbrains-plugin/messages/ProtostuffBundle.properties

@@ -10,6 +10,9 @@ action.disable.conflicting.plugins=We detected that you have other plugins for \
   </ul>\
   <p>It might lead to stability issues.\
   <p><p>Please <a href="disable">disable other plugins and restart IDE</a>.
+
+element.context.display={0} in {1}
+
 error.invalid.tag.not.in.range=Invalid tag: {0}, allowed range is [{1} ... {2}) and ({3} ... {4}]
 error.duplicate.field.tag=Duplicate field tag: {0}
 error.duplicate.field.name=Duplicate field name: {0}
@@ -20,5 +23,5 @@ error.duplicate.constant.value=Duplicate constant value: {0}
 error.duplicate.method.name=Duplicate RPC method name: {0}
 error.missing.field.label=Missing field label
 error.illegal.field.label=Field label "{0}" is not allowed in proto3
-element.context.display={0} in {1}
 error.default.value.not.supported=Default values are not supported in proto3
+error.groups.not.supported=Groups are not supported in proto3

src/test/java/io/protostuff/jetbrains/plugin/annotator/ProtoErrorsAnnotatorTest.java

@@ -82,6 +82,10 @@ public void testProto3IllegalDefaultValueOption() {
         check();
     }
 
+    public void testProto3IllegalGroup() {
+        check();
+    }
+
     private void check() {
         String file = getTestName(false) + ".proto";
         myFixture.configureByFiles(file);

src/test/resources/annotator/Proto3IllegalGroup.proto

@@ -0,0 +1,9 @@
+syntax = "proto3";
+
+package annotator;
+
+message TestMessage {
+    <error descr="Groups are not supported in proto3">optional group group = 1 {
+
+    }</error>
+}