Consider the case where types are nil

Fix #19

Author: ksss

lib/rubocop/cop/yard/helper.rb

@@ -19,7 +19,7 @@ def parse_type(type)
 
         def each_types_explainer(docstring, &block)
           docstring.tags.each do |tag|
-            types = extract_tag_types(tag)
+            types = extract_tag_types(tag) or next
 
             begin
               types_explainers = parse_type(types.join(', '))

lib/rubocop/cop/yard/mismatch_name.rb

@@ -57,6 +57,7 @@ def on_def(node)
               end
 
               next unless node.arguments.none? { |arg_node| tag.name.to_sym == arg_node.name }
+              next unless types
 
               begin
                 parse_type(types.join(', '))

lib/rubocop/cop/yard/tag_type_syntax.rb

@@ -27,7 +27,7 @@ def on_new_investigation
         def check(comment)
           docstring = comment.text.gsub(/\A#\s*/, '')
           ::YARD::DocstringParser.new.parse(docstring).tags.each do |tag|
-            types = extract_tag_types(tag)
+            types = extract_tag_types(tag) or next
 
             check_syntax_error(comment) do
               parse_type(types.join(', '))

sig/rubocop/yard.rbs

@@ -5,12 +5,32 @@ module RuboCop
   end
   module Cop
     module YARD
+      type tag_types = YARD::Tags::TypesExplainer::Type
+                     | ::YARD::Tags::TypesExplainer::CollectionType
+                     | ::YARD::Tags::TypesExplainer::FixedCollectionType
+                     | ::YARD::Tags::TypesExplainer::HashCollectionType
       class CollectionType
-        type t = YARD::Tags::TypesExplainer::Type
-               | ::YARD::Tags::TypesExplainer::CollectionType
-               | ::YARD::Tags::TypesExplainer::FixedCollectionType
-               | ::YARD::Tags::TypesExplainer::HashCollectionType
-        private def check_mismatch_collection_type: (untyped comment, t types_explainer) -> void
+        private def check_mismatch_collection_type: (untyped comment, tag_types types_explainer) -> void
+      end
+
+      module Helper
+        def extract_tag_types: (::YARD::Tags::OptionTag | ::YARD::Tags::Tag tag) -> Array[String]?
+      end
+
+      class TagTypeSyntax < ::RuboCop::Cop::Base
+        include YARD::Helper
+
+        private
+
+        def check: (::Parser::Source::Comment comment) -> void
+        def check_syntax_error: (::Parser::Source::Comment comment) { () -> void } -> void
+        def inline_comment?: (::Parser::Source::Comment comment) -> bool
+        def include_yard_tag?: (::Parser::Source::Comment comment) -> bool
+        def tag_range_for_comment: (::Parser::Source::Comment comment) -> untyped
+      end
+
+      class MismatchName < ::RuboCop::Cop::Base
+        include YARD::Helper
       end
     end
   end

smoke/collection_style_long.rb

@@ -12,3 +12,12 @@ class Foo
   def foo
   end
 end
+
+# https://github.com/ksss/rubocop-yard/issues/19
+class Test
+  # @param [Hash{Symbol=>Object}] options The options
+  # @option [Integer] :op Option associated to no param
+  def test(options)
+  end
+end
+

smoke/collection_style_short.rb

@@ -12,3 +12,11 @@ class Foo
   def foo
   end
 end
+
+# https://github.com/ksss/rubocop-yard/issues/19
+class Test
+  # @param [Hash{Symbol=>Object}] options The options
+  # @option [Integer] :op Option associated to no param
+  def test(options)
+  end
+end

smoke/generated/collection_style_long_correct.rb

@@ -12,3 +12,12 @@ class Foo
   def foo
   end
 end
+
+# https://github.com/ksss/rubocop-yard/issues/19
+class Test
+  # @param [Hash{Symbol=>Object}] options The options
+  # @option [Integer] :op Option associated to no param
+  def test(options)
+  end
+end
+

smoke/generated/collection_style_short.json

@@ -73,12 +73,28 @@
             "line": 11,
             "column": 3
           }
+        },
+        {
+          "severity": "convention",
+          "message": "`Hash{Symbol=>Object}` is using long style syntax",
+          "cop_name": "YARD/CollectionStyle",
+          "corrected": false,
+          "correctable": true,
+          "location": {
+            "start_line": 18,
+            "start_column": 3,
+            "last_line": 18,
+            "last_column": 53,
+            "length": 51,
+            "line": 18,
+            "column": 3
+          }
         }
       ]
     }
   ],
   "summary": {
-    "offense_count": 4,
+    "offense_count": 5,
     "target_file_count": 1,
     "inspected_file_count": 1
   }

smoke/generated/collection_style_short_correct.rb

@@ -12,3 +12,11 @@ class Foo
   def foo
   end
 end
+
+# https://github.com/ksss/rubocop-yard/issues/19
+class Test
+  # @param [{Symbol => Object}] options The options
+  # @option [Integer] :op Option associated to no param
+  def test(options)
+  end
+end