Merge pull request #49 from cordmata/develop

Allow user creation on first login to be optional.

Author: dstegelman

README.md

@@ -138,10 +138,16 @@ Then, add the ``gateway`` decorator to a view:
 To show a custom forbidden page, set ``CAS_CUSTOM_FORBIDDEN`` to a ``path.to.some_view``.  Otherwise,
 a generic ``HttpResponseForbidden`` will be returned.
 
-## Require SSL login
+## Require SSL Login
 
 To force the service url to always target HTTPS, set ``CAS_FORCE_SSL_SERVICE_URL`` to ``True``.
 
+## Automatically Create Users on First Login
+
+By default, a stub user record will be created on the first successful CAS authentication
+using the username in the response. If this behavior is not desired set
+``CAS_AUTO_CREATE_USER`` to ``Flase``.
+
 ## Proxy Tickets
 
 This fork also includes

cas/__init__.py

@@ -19,6 +19,7 @@
     'CAS_CUSTOM_FORBIDDEN': None,
     'CAS_PGT_FETCH_WAIT': True,
     'CAS_FORCE_SSL_SERVICE_URL': False,
+    'CAS_AUTO_CREATE_USER': True,
 }
 
 for key, value in _DEFAULTS.items():

cas/backends.py

@@ -237,8 +237,11 @@ def authenticate(self, ticket, service):
             user = User.objects.get(username__iexact=username)
         except User.DoesNotExist:
             # user will have an "unusable" password
-            user = User.objects.create_user(username, '')
-            user.save()
+            if settings.CAS_AUTO_CREATE_USER:
+                user = User.objects.create_user(username, '')
+                user.save()
+            else:
+                user = None
         return user
 
     def get_user(self, user_id):

cas/tests/test_backend.py

@@ -13,4 +13,18 @@ def setUp(self):
     def test_get_user(self):
         backend = CASBackend()
 
-        self.assertEqual(backend.get_user(self.user.pk), self.user)
+        self.assertEqual(backend.get_user(self.user.pk), self.user)
+
+    @mock.patch('cas.backends._verify')
+    def test_user_auto_create(self, verify):
+        username = 'faker'
+        verify.return_value = username
+        backend = CASBackend()
+
+        with self.settings(CAS_AUTO_CREATE_USER=False):
+            user = backend.authenticate('fake', 'fake')
+            self.assertIsNone(user)
+
+        with self.settings(CAS_AUTO_CREATE_USER=True):
+            user = backend.authenticate('fake', 'fake')
+            self.assertEquals(user.username, username)