Small performance improvement

mreiden · ksubileau · commit 2c71a6bef9ce · 2018-10-22T00:15:00.000+02:00
diff --git a/lib/ColorThief/VBox.php b/lib/ColorThief/VBox.php
@@ -168,10 +168,11 @@ public function contains(array $rgbValue, $rshift = ColorThief::RSHIFT)
      */
     public function longestAxis()
     {
-        $colorWidth['r'] = $this->r2 - $this->r1;
-        $colorWidth['g'] = $this->g2 - $this->g1;
-        $colorWidth['b'] = $this->b2 - $this->b1;
+        // Color-Width for RGB
+        $red = $this->r2 - $this->r1;
+        $green = $this->g2 - $this->g1;
+        $blue = $this->b2 - $this->b1;
 
-        return array_search(max($colorWidth), $colorWidth);
+        return $red >= $green && $red >= $blue ? 'r' : ($green >= $red && $green >= $blue ? 'g' : 'b');
     }
 }

Original file line number	Diff line number	Diff line change
`@@ -168,10 +168,11 @@ public function contains(array $rgbValue, $rshift = ColorThief::RSHIFT)`
`168`	`168`	`*/`
`169`	`169`	`public function longestAxis()`
`170`	`170`	`{`
`171`		`- $colorWidth['r'] = $this->r2 - $this->r1;`
`172`		`- $colorWidth['g'] = $this->g2 - $this->g1;`
`173`		`- $colorWidth['b'] = $this->b2 - $this->b1;`
	`171`	`+ // Color-Width for RGB`
	`172`	`+ $red = $this->r2 - $this->r1;`
	`173`	`+ $green = $this->g2 - $this->g1;`
	`174`	`+ $blue = $this->b2 - $this->b1;`
`174`	`175`
`175`		`- return array_search(max($colorWidth), $colorWidth);`
	`176`	`+ return $red >= $green && $red >= $blue ? 'r' : ($green >= $red && $green >= $blue ? 'g' : 'b');`
`176`	`177`	`}`
`177`	`178`	`}`