Merge pull request #33 from ksylvan/0606-implement-run-pattern

Implement `fabric_run_pattern` Core with Testing Overhaul

Author: ksylvan

.gitignore

@@ -198,7 +198,7 @@ node_modules/
 .cursor
 
 # As well as the generated PRD
-scripts
+scripts/*
 
 # Logs
 logs

.vscode/mcp.json

@@ -0,0 +1,10 @@
+{
+	"servers": {
+		"FabricMCP": {
+			"type": "stdio",
+			"command": "uv",
+			"args": ["run", "fabric-mcp", "--transport", "stdio"],
+			"cwd": "${workspaceFolder}"
+		}
+	}
+}

Makefile

@@ -1,11 +1,14 @@
 # Makefile for
 #
 
-.PHONY: _default bootstrap build clean coverage coverage-html \
-	coverage-show dev format help lint mcp-inspector merge tag test test-fast test-serial
+.PHONY: __default _check_unused bootstrap build clean coverage coverage-html \
+	coverage-show dev format help lint mcp-inspector merge tag \
+	test test-fast test-serial vulture
 
 COVERAGE_FAIL_UNDER := 90
 PACKAGE_PATH := src/fabric_mcp
+TESTS_PATH := tests
+
 
 # The node package manager could be npm, but why? pnpm is faster and more efficient
 # This is only needed if you are using the fastmcp dev server.
@@ -15,7 +18,10 @@ STDIO_SERVER_SRC_FOR_MCP_INSPECTOR := $(PACKAGE_PATH)/server_stdio.py
 
 VERSION := $(shell uv run hatch version)
 
-_default: help
+__default: help
+
+_check_unused:
+	uv run python tests/scripts/check_shared_utils
 
 bootstrap:
 	uv sync --dev
@@ -28,6 +34,8 @@ build:
 
 clean:
 	rm -rf .venv dist node_modules
+	find $(PACKAGE_PATH) -name "*.pyc" -delete
+	find $(TESTS_PATH) -name "*.pyc" -delete
 
 coverage:
 	uv run pytest -n auto --cov=$(PACKAGE_PATH) \
@@ -78,12 +86,13 @@ help:
 	@echo "  test          Run tests with parallel execution"
 	@echo "  test-fast     Run tests with optimized parallel execution (skips linting)"
 	@echo "  test-serial   Run tests serially (single-threaded)"
+	@echo "  vulture       Run Vulture to check for dead code and unused imports"
 
-lint:
+lint: vulture
 	uv run ruff format --check .
 	uv run ruff check .
-	uv run pylint --fail-on=W0718 $(PACKAGE_PATH) tests
-	uv run pyright $(PACKAGE_PATH) tests
+	uv run pylint --fail-on=W0718 $(PACKAGE_PATH) $(TESTS_PATH)
+	uv run pyright $(PACKAGE_PATH) $(TESTS_PATH)
 
 merge:
 	@echo "This will merge develop into main and push to origin."
@@ -129,3 +138,7 @@ test-fast:
 test-serial: lint
 	uv run pytest -v
 
+# Vulture - static analysis for dead code
+# Also checks for unimported .py files in tests/shared/
+vulture: _check_unused
+	uv run vulture

cspell.json

@@ -15,7 +15,9 @@
 		"delenv",
 		"Dockerization",
 		"docstrings",
+		"elif",
 		"excinfo",
+		"fastapi",
 		"forcelist",
 		"grokai",
 		"groq",
@@ -34,8 +36,10 @@
 		"Miessler",
 		"Miessler's",
 		"modelcontextprotocol",
+		"mypy",
 		"ollama",
 		"openrouter",
+		"popleft",
 		"pylint",
 		"pylintrc",
 		"pypi",
@@ -46,6 +50,7 @@
 		"restapi",
 		"sdist",
 		"signum",
+		"startswith",
 		"Streamable",
 		"testpypi",
 		"toupper",

docs/contributing-cheatsheet.md

@@ -16,6 +16,11 @@ git checkout -b feature/my-change
 
 # make changes
 
+# Run tests and ensure coverage targets met
+# (testing also runs linters and the "vulture" tool)
+make test
+make coverage
+
 git commit -m "feat: my changes"  # ← Hooks run, ensure good practices
 git push -u origin feature/my-change
 ```

docs/contributing-detailed.md

@@ -136,6 +136,7 @@ Contributors will primarily interact with the following tools, largely configure
 | `pylint` | Linting (additional checks) | `make lint` (`uv run pylint`) | `pyproject.toml` (or `.pylintrc`) |
 | `pytest` | Automated Testing | `make test` (`uv run pytest`) | `pyproject.toml` |
 | `pyright` | Static Type Checking | `make lint` (`uv run pyright`) | `pyproject.toml` |
+| `vulture` | Check for dead code, unused variables/functions | `make vulture` (`uv run vulture`) | `pyproject.toml` |
 
 This table offers a consolidated summary, helping contributors quickly identify the main tools, their functions, common commands, and their configuration sources.
 

docs/contributing.md

@@ -80,6 +80,7 @@ make dev           # Start FastMCP dev server with MCP inspector
 make mcp-inspector # Start standalone MCP inspector
 make build         # Build the project
 make clean         # Remove build/test artifacts
+make vulture       # Run the vulture tool (check for dead code)
 ```
 
 ## Code Style and Quality