feat: add <!DOCTYPE html> by default (#44)

kt3k · web-flow · commit 1fedd53e2c76 · 2022-07-12T17:42:47.000+09:00
diff --git a/build_test.ts b/build_test.ts
@@ -10,6 +10,6 @@ Deno.test("cli.ts build <entrypoint> --dist-dir <path> -- builds the site into g
   );
   assertEquals(
     await Deno.readTextFile(join(tempdir, "index.html")),
-    "<html><head></head><body><div>aaa</div>\n</body></html>",
+    "<!DOCTYPE html><html><head></head><body><div>aaa</div>\n</body></html>",
   );
 });
diff --git a/generate_assets.ts b/generate_assets.ts
@@ -147,6 +147,8 @@ type Asset = {
   createFileObject(params: CreateFileObjectParams): Promise<File[]>;
 };
 
+const docType = encoder.encode("<!DOCTYPE html>");
+
 /** HtmlAsset represents the html file */
 class HtmlAsset implements Asset {
   static async create(path: string): Promise<HtmlAsset> {
@@ -182,7 +184,7 @@ class HtmlAsset implements Asset {
 
   createFileObject(_params: CreateFileObjectParams) {
     return Promise.resolve([Object.assign(
-      new Blob([encoder.encode(this.#doc.body.parentElement!.outerHTML)]),
+      new Blob([docType, encoder.encode(this.#doc.documentElement!.outerHTML)]),
       { name: this.#filename },
     )]);
   }
diff --git a/serve_test.ts b/serve_test.ts
@@ -19,15 +19,15 @@ Deno.test("cli.ts serve <entrypoint> --port <port> --livereload-port <port> -- s
   let res = await fetch("http://localhost:4567/index.html");
   assertEquals(
     await res.text(),
-    `<html><head></head><body><div>aaa</div>\n<script src="http://localhost:34567/livereload.js"></script></body></html>`,
+    `<!DOCTYPE html><html><head></head><body><div>aaa</div>\n<script src="http://localhost:34567/livereload.js"></script></body></html>`,
   );
 
   // Non existent path returns the same response as the main html.
   // This is useful for apps which use client side routing.
   res = await fetch("http://localhost:4567/asdf");
   assertEquals(
     await res.text(),
-    `<html><head></head><body><div>aaa</div>\n<script src="http://localhost:34567/livereload.js"></script></body></html>`,
+    `<!DOCTYPE html><html><head></head><body><div>aaa</div>\n<script src="http://localhost:34567/livereload.js"></script></body></html>`,
   );
   p.close();
 });
