Skip to content

Commit 0b01409

Browse files
authored
DPL Analysis: re-enable prefetching (AliceO2Group#13559)
Now that ROOT supports prefetching with bulk reading, we can reenable this which should cut in half the number of IOPS for the general case.
1 parent c2ff3e0 commit 0b01409

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

Framework/Core/src/TableTreeHelpers.cxx

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -547,14 +547,14 @@ void TreeToTable::addAllColumns(TTree* tree, std::vector<std::string>&& names)
547547
if (mBranchReaders.empty()) {
548548
throw runtime_error("No columns will be read");
549549
}
550-
//tree->SetCacheSize(50000000);
551-
// FIXME: see https://github.com/root-project/root/issues/8962 and enable
552-
// again once fixed.
553-
//tree->SetClusterPrefetch(true);
554-
//for (auto& reader : mBranchReaders) {
555-
// tree->AddBranchToCache(reader->branch());
556-
//}
557-
//tree->StopCacheLearningPhase();
550+
// Was affected by https://github.com/root-project/root/issues/8962
551+
// Re-enabling this seems to cut the number of IOPS in half
552+
tree->SetCacheSize(25000000);
553+
tree->SetClusterPrefetch(true);
554+
for (auto& reader : mBranchReaders) {
555+
tree->AddBranchToCache(reader->branch());
556+
}
557+
tree->StopCacheLearningPhase();
558558
}
559559

560560
void TreeToTable::setLabel(const char* label)

0 commit comments

Comments
 (0)