Fix the thickness of logical volumes for kTurboStaves and kStaggered configurations of the tracker (AliceO2Group#14268)

Author: danielbattistini

Detectors/Upgrades/ALICE3/TRK/simulation/include/TRKSimulation/TRKLayer.h

@@ -45,6 +45,9 @@ class TRKLayer
   void createLayer(TGeoVolume* motherVolume);
 
  private:
+  // TGeo objects outside logical volumes can cause errors. Only used in case of kStaggered and kTurboStaves layouts
+  static constexpr float mLogicalVolumeThickness = 1;
+
   int mLayerNumber;
   std::string mLayerName;
   float mInnerRadius;

Detectors/Upgrades/ALICE3/TRK/simulation/src/TRKLayer.cxx

@@ -120,7 +120,7 @@ TGeoVolume* TRKLayer::createStave(std::string type, double width)
     staveVol->AddNode(chipVol, 1, nullptr);
   } else if (type == "staggered") {
     double width = mModuleWidth * 2; // Each stave has two modules (based on the LOI design)
-    stave = new TGeoBBox(width / 2, mChipThickness / 2, mZ / 2);
+    stave = new TGeoBBox(width / 2, mLogicalVolumeThickness / 2, mZ / 2);
     TGeoVolume* chipVolLeft = createChip("flat", mModuleWidth);
     TGeoVolume* chipVolRight = createChip("flat", mModuleWidth);
     staveVol = new TGeoVolume(staveName.c_str(), stave, medAir);
@@ -152,7 +152,11 @@ void TRKLayer::createLayer(TGeoVolume* motherVolume)
               chipName = o2::trk::GeometryTGeo::getTRKChipPattern() + std::to_string(mLayerNumber),
               sensName = Form("%s%d", GeometryTGeo::getTRKSensorPattern(), mLayerNumber);
 
-  TGeoTube* layer = new TGeoTube(mInnerRadius, mInnerRadius + mChipThickness, mZ / 2);
+  double layerThickness = mChipThickness;
+  if (mLayout != eLayout::kCylinder) {
+    layerThickness = mLogicalVolumeThickness;
+  }
+  TGeoTube* layer = new TGeoTube(mInnerRadius - 0.333 * layerThickness, mInnerRadius + 0.667 * layerThickness, mZ / 2);
 
   TGeoVolume* layerVol = new TGeoVolume(mLayerName.c_str(), layer, medAir);
   layerVol->SetLineColor(kYellow);