Merge 865586f into sapling-pr-archive-ktf

Author: ktf

Framework/Core/src/DPLWebSocket.cxx

@@ -167,10 +167,10 @@ struct GUIWebSocketHandler : public WebSocketHandler {
       }
     }
   }
-  void endFragmentation() override{};
-  void control(char const* frame, size_t s) override{};
-  void beginChunk() override{};
-  void endChunk() override{};
+  void endFragmentation() override {};
+  void control(char const* frame, size_t s) override {};
+  void beginChunk() override {};
+  void endChunk() override {};
 
   /// The driver context were we want to accumulate changes
   /// which we got from the websocket.
@@ -415,6 +415,7 @@ void websocket_client_callback(uv_stream_t* stream, ssize_t nread, const uv_buf_
   try {
     LOG(debug) << "Data received from server";
     parse_http_request(buf->base, nread, context->client);
+    free(buf->base);
   } catch (RuntimeErrorRef& ref) {
     auto& err = o2::framework::error_from_ref(ref);
     LOG(error) << "Error while parsing request: " << err.what;

Framework/Core/src/Expressions.cxx

@@ -67,7 +67,7 @@ size_t Filter::designateSubtrees(Node* node, size_t index)
   path.emplace(node, 0);
 
   while (!path.empty()) {
-    auto& top = path.top();
+    auto top = path.top();
     top.node_ptr->index = local_index;
     path.pop();
     if (top.node_ptr->condition != nullptr) {
@@ -277,7 +277,7 @@ Operations createOperations(Filter const& expression)
 
   // while the stack is not empty
   while (!path.empty()) {
-    auto& top = path.top();
+    auto top = path.top();
 
     // create operation spec, pop the node and add its children
     auto operationSpec =
@@ -458,7 +458,7 @@ std::shared_ptr<gandiva::Filter>
 {
   std::shared_ptr<gandiva::Filter> filter;
   auto s = gandiva::Filter::Make(Schema,
-                                 std::move(condition),
+                                 condition,
                                  &filter);
   if (!s.ok()) {
     throw runtime_error_f("Failed to create filter: %s", s.ToString().c_str());

Framework/Core/src/runDataProcessing.cxx

@@ -491,6 +491,7 @@ void websocket_callback(uv_stream_t* stream, ssize_t nread, const uv_buf_t* buf)
   } catch (WSError& e) {
     LOG(error) << "Error while parsing request: " << e.message;
     handler->error(e.code, e.message.c_str());
+    free(buf->base);
   }
 }