Avoid asking for reviews in directly distributed app

You'd expect StoreKit to do nothing in this case, but it seems to always present the dialog...

Author: kthchew

ExtendFS.xcodeproj/project.pbxproj

@@ -319,7 +319,7 @@
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 12;
+				CURRENT_PROJECT_VERSION = 13;
 				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = dwarf;
 				DEVELOPMENT_TEAM = YN43D87323;
@@ -387,7 +387,7 @@
 				CLANG_WARN_UNREACHABLE_CODE = YES;
 				CLANG_WARN__DUPLICATE_METHOD_MATCH = YES;
 				COPY_PHASE_STRIP = NO;
-				CURRENT_PROJECT_VERSION = 12;
+				CURRENT_PROJECT_VERSION = 13;
 				DEAD_CODE_STRIPPING = YES;
 				DEBUG_INFORMATION_FORMAT = "dwarf-with-dsym";
 				DEVELOPMENT_TEAM = YN43D87323;

ExtendFS/ContentView.swift

@@ -90,11 +90,33 @@ struct ContentView: View {
 
         self.ext4ExtensionState = states[ext4ExtensionIdentifier] ?? .notDetermined
 
-        let timeSinceLastAskedForRating = lastAskedForRating.timeIntervalSinceNow.magnitude
-        let secondsPerMonth = Double(60 * 60 * 24 * 7 * 30)
-        if appearsActive && timeSinceLastAskedForRating > secondsPerMonth {
-            lastAskedForRating = Date.now
-            requestReview()
+        if !isSignedForDirectDistribution() {
+            let timeSinceLastAskedForRating = lastAskedForRating.timeIntervalSinceNow.magnitude
+            let secondsPerMonth = Double(60 * 60 * 24 * 7 * 30)
+            if appearsActive && timeSinceLastAskedForRating > secondsPerMonth {
+                lastAskedForRating = Date.now
+                requestReview()
+            }
+        }
+    }
+    
+    func isSignedForDirectDistribution() -> Bool {
+        var code: SecCode? = nil
+        SecCodeCopySelf(SecCSFlags(), &code)
+        guard let code else { return true }
+        var staticCode: SecStaticCode? = nil
+        SecCodeCopyStaticCode(code, SecCSFlags(), &staticCode)
+        guard let staticCode else { return true }
+        var dict: CFDictionary?
+        SecCodeCopySigningInformation(staticCode, SecCSFlags(rawValue: kSecCSSigningInformation), &dict)
+        guard let info = dict as? [CFString: Any], let certificates = info[kSecCodeInfoCertificates] as? [SecCertificate] else {
+            return true
+        }
+        return certificates.contains { cert in
+            var commonName: CFString? = nil
+            SecCertificateCopyCommonName(cert, &commonName)
+            guard let commonName = commonName as? String else { return false }
+            return commonName.contains("Developer ID Application")
         }
     }