fix GetDiff to use executeRaw() internally. (#84)

Author: ktrysmt

Makefile

@@ -1,23 +1,23 @@
 .DEFAULT_GOAL := help
 
 env: ## check env for e2e testing
-	ifndef BITBUCKET_TEST_USERNAME
-	  $(error `BITBUCKET_TEST_USERNAME` is not set)
-	endif
-	ifndef BITBUCKET_TEST_PASSWORD
-	  $(error `BITBUCKET_TEST_PASSWORD` is not set)
-	endif
-	ifndef BITBUCKET_TEST_OWNER
-	  $(error `BITBUCKET_TEST_OWNER` is not set)
-	endif
-	ifndef BITBUCKET_TEST_REPOSLUG
-	  $(error `BITBUCKET_TEST_REPOSLUG` is not set)
-	endif
+ifndef BITBUCKET_TEST_USERNAME
+	$(error `BITBUCKET_TEST_USERNAME` is not set)
+endif
+ifndef BITBUCKET_TEST_PASSWORD
+	$(error `BITBUCKET_TEST_PASSWORD` is not set)
+endif
+ifndef BITBUCKET_TEST_OWNER
+	$(error `BITBUCKET_TEST_OWNER` is not set)
+endif
+ifndef BITBUCKET_TEST_REPOSLUG
+	$(error `BITBUCKET_TEST_REPOSLUG` is not set)
+endif
 
 test: env ## run go test all
 	go test -v ./tests
 
-help: ## print this help 
+help: ## print this help
 	@grep -E '^[a-zA-Z_-]+:.*?## .*$$' $(MAKEFILE_LIST) | awk 'BEGIN {FS = ":.*?## "}; {printf "\033[36m%-30s\033[0m %s\n", $$1, $$2}'
 
 .PHONY: test help

diff.go

@@ -6,7 +6,7 @@ type Diff struct {
 
 func (d *Diff) GetDiff(do *DiffOptions) (interface{}, error) {
 	urlStr := d.c.requestUrl("/repositories/%s/%s/diff/%s", do.Owner, do.RepoSlug, do.Spec)
-	return d.c.execute("GET", urlStr, "")
+	return d.c.executeRaw("GET", urlStr, "diff")
 }
 
 func (d *Diff) GetPatch(do *DiffOptions) (interface{}, error) {

go.mod

@@ -3,7 +3,7 @@ module github.com/ktrysmt/go-bitbucket
 go 1.12
 
 require (
-	github.com/golang/protobuf v1.0.0 // indirect
+	github.com/golang/protobuf v1.0.0
 	github.com/k0kubun/colorstring v0.0.0-20150214042306-9440f1994b88 // indirect
 	github.com/k0kubun/pp v2.3.0+incompatible
 	github.com/mattn/go-colorable v0.0.9 // indirect

tests/diff_test.go

@@ -0,0 +1,42 @@
+package tests
+
+import (
+	"os"
+	"testing"
+
+	"github.com/k0kubun/pp"
+	"github.com/ktrysmt/go-bitbucket"
+)
+
+func TestDiff(t *testing.T) {
+
+	user := os.Getenv("BITBUCKET_TEST_USERNAME")
+	pass := os.Getenv("BITBUCKET_TEST_PASSWORD")
+	owner := os.Getenv("BITBUCKET_TEST_OWNER")
+	repo := os.Getenv("BITBUCKET_TEST_REPOSLUG")
+
+	if user == "" {
+		t.Error("BITBUCKET_TEST_USERNAME is empty.")
+	}
+
+	if pass == "" {
+		t.Error("BITBUCKET_TEST_PASSWORD is empty.")
+	}
+
+	c := bitbucket.NewBasicAuth(user, pass)
+
+	spec := "master..develop"
+
+	opt := &bitbucket.DiffOptions{
+		Owner:    owner,
+		RepoSlug: repo,
+		Spec:     spec,
+	}
+	res, _ := c.Repositories.Diff.GetDiff(opt)
+
+	pp.Println(res)
+
+	if res == nil {
+		t.Error("It could not get the raw response.")
+	}
+}