Remove unnecessary PHP version checks (#996)

Author: kubawerlos

.dev-tools/phpstan.neon

@@ -12,12 +12,6 @@ parameters:
       count: 1
       path: ../src/Analyzer/Analysis/ConstructorAnalysis.php
 
-    -
-      message: '#^Comparison operation "\>\=" between int\<80400, 80499\> and 70400 is always true\.$#'
-      identifier: greaterOrEqual.alwaysTrue
-      count: 1
-      path: ../src/Fixer/NumericLiteralSeparatorFixer.php
-
     -
       message: '#^Comparison operation "\>\=" between int\<80400, 80499\> and 80000 is always true\.$#'
       identifier: greaterOrEqual.alwaysTrue
@@ -30,12 +24,6 @@ parameters:
       count: 1
       path: ../src/Fixer/StringableInterfaceFixer.php
 
-    -
-      message: '#^Comparison operation "\>\=" between int\<80400, 80499\> and 70300 is always true\.$#'
-      identifier: greaterOrEqual.alwaysTrue
-      count: 1
-      path: ../tests/Analyzer/FunctionAnalyzerTest.php
-
     -
       message: '#^Parameter \#2 \$haystack of static method PHPUnit\\Framework\\Assert\:\:assertStringContainsString\(\) expects string, mixed given\.$#'
       identifier: argument.type
@@ -60,18 +48,6 @@ parameters:
       count: 1
       path: ../tests/Fixer/AbstractFixerTestCase.php
 
-    -
-      message: '#^Comparison operation "\>\=" between int\<80400, 80499\> and 70300 is always true\.$#'
-      identifier: greaterOrEqual.alwaysTrue
-      count: 1
-      path: ../tests/Fixer/NoUselessDirnameCallFixerTest.php
-
-    -
-      message: '#^Comparison operation "\>\=" between int\<80400, 80499\> and 70400 is always true\.$#'
-      identifier: greaterOrEqual.alwaysTrue
-      count: 1
-      path: ../tests/Fixer/PhpdocNoIncorrectVarAnnotationFixerTest.php
-
     -
       message: '#^Method Tests\\FixersTest\:\:fixerNamesFromCollection\(\) should return array\<int, string\> but returns array\<string\>\.$#'
       identifier: return.type

src/Fixer/NumericLiteralSeparatorFixer.php

@@ -104,7 +104,7 @@ public function getPriority(): int
 
     public function isCandidate(Tokens $tokens): bool
     {
-        return \PHP_VERSION_ID >= 70400 && $tokens->isAnyTokenKindsFound([\T_DNUMBER, \T_LNUMBER]);
+        return $tokens->isAnyTokenKindsFound([\T_DNUMBER, \T_LNUMBER]);
     }
 
     public function isRisky(): bool

tests/Analyzer/FunctionAnalyzerTest.php

@@ -137,22 +137,20 @@ public static function provideGettingArgumentsCases(): iterable
             1,
         ];
 
-        if (\PHP_VERSION_ID >= 70300) {
-            yield 'argument with trailing comma' => [
-                [new ArgumentAnalysis(3, 3, false)],
-                '<?php foo($x);',
-                1,
-            ];
-
-            yield 'multiple arguments with trailing comma' => [
-                [
-                    new ArgumentAnalysis(3, 3, true),
-                    new ArgumentAnalysis(6, 6, true),
-                    new ArgumentAnalysis(9, 9, true),
-                ],
-                '<?php foo(1, 2, 3,);',
-                1,
-            ];
-        }
+        yield 'argument with trailing comma' => [
+            [new ArgumentAnalysis(3, 3, false)],
+            '<?php foo($x);',
+            1,
+        ];
+
+        yield 'multiple arguments with trailing comma' => [
+            [
+                new ArgumentAnalysis(3, 3, true),
+                new ArgumentAnalysis(6, 6, true),
+                new ArgumentAnalysis(9, 9, true),
+            ],
+            '<?php foo(1, 2, 3,);',
+            1,
+        ];
     }
 }

tests/Fixer/NoUselessDirnameCallFixerTest.php

@@ -88,16 +88,14 @@ public static function provideFixCases(): iterable
         ];
 
         // test with trailing comma
-        if (\PHP_VERSION_ID >= 70300) {
-            yield [
-                '<?php __DIR__ . "/../path";',
-                '<?php dirname(__DIR__,) . "/path";',
-            ];
+        yield [
+            '<?php __DIR__ . "/../path";',
+            '<?php dirname(__DIR__,) . "/path";',
+        ];
 
-            yield [
-                '<?php __DIR__ . "/../../../path";',
-                '<?php \\dirname(__DIR__,3,) . "/path";',
-            ];
-        }
+        yield [
+            '<?php __DIR__ . "/../../../path";',
+            '<?php \\dirname(__DIR__,3,) . "/path";',
+        ];
     }
 }

tests/Fixer/PhpdocNoIncorrectVarAnnotationFixerTest.php

@@ -237,27 +237,25 @@ class Foo
 ',
         ];
 
-        if (\PHP_VERSION_ID >= 70400) {
-            yield 'keep correct PHPDoc for class properties, PHP 7.4' => [
-                '<?php class Foo
-                {
-                    /** @var array */
-                    private array $array;
+        yield 'keep correct PHPDoc for class properties, PHP 7.4' => [
+            '<?php class Foo
+            {
+                /** @var array */
+                private array $array;
 
-                    /** @var bool */
-                    private bool $boolean;
+                /** @var bool */
+                private bool $boolean;
 
-                    /** @var null|string */
-                    private ?string $nullableString;
+                /** @var null|string */
+                private ?string $nullableString;
 
-                    /** @var Bar */
-                    private Bar $bar;
+                /** @var Bar */
+                private Bar $bar;
 
-                    /** @var Vendor\\Baz */
-                    private Vendor\\Baz $baz;
-                }',
-            ];
-        }
+                /** @var Vendor\\Baz */
+                private Vendor\\Baz $baz;
+            }',
+        ];
 
         yield 'remove PHPDoc for class properties' => [
             '<?php