Update minimum PHP version to 7.4 (#744)

Author: kubawerlos

.dev-tools/src/Priority/PriorityFixer.php

@@ -81,9 +81,7 @@ public function getFixerToRunBeforeNames(): array
     private function getFixerNames(array $priorityFixers): array
     {
         $fixers = \array_map(
-            static function (self $priorityFixer): string {
-                return (new \ReflectionObject($priorityFixer->fixer))->getShortName();
-            },
+            static fn (self $priorityFixer): string => (new \ReflectionObject($priorityFixer->fixer))->getShortName(),
             $priorityFixers
         );
 

.dev-tools/src/Readme/ReadmeCommand.php

@@ -198,9 +198,7 @@ private function fixers(): string
 
                 foreach ($fixer->getConfigurationDefinition()->getOptions() as $option) {
                     if ($option->getAllowedValues() !== null) {
-                        $allowed = \array_map(static function (string $value): string {
-                            return \sprintf('\'%s\'', $value);
-                        }, $option->getAllowedValues());
+                        $allowed = \array_map(static fn (string $value): string => \sprintf('\'%s\'', $value), $option->getAllowedValues());
                     } else {
                         /** @var array<string> $allowed */
                         $allowed = $option->getAllowedTypes();

.github/workflows/ci.yaml

@@ -27,17 +27,14 @@ jobs:
       matrix:
         os: [ macos-latest, ubuntu-latest, windows-latest ]
         php-version: [ '7.4', '8.1' ]
+        composer-flags: [ '' ]
         coverage-driver: [ none ]
         install-fixer-from-master-branch: [ false ]
         include:
           - os: ubuntu-latest
-            php-version: '7.2'
-            composer_flags: '--prefer-lowest'
+            php-version: '7.4'
+            composer-flags: '--prefer-lowest'
             description: 'with lowest dependencies'
-          - os: ubuntu-latest
-            php-version: '7.2'
-          - os: ubuntu-latest
-            php-version: '7.3'
           - os: ubuntu-latest
             php-version: '8.0'
           - os: ubuntu-latest
@@ -50,7 +47,7 @@ jobs:
             description: 'with PHP CS Fixer from master'
           - os: ubuntu-latest
             php-version: '8.2'
-            composer_flags: '--ignore-platform-reqs'
+            composer-flags: '--ignore-platform-reqs'
     runs-on: ${{ matrix.os }}
     timeout-minutes: 10
     env:
@@ -70,7 +67,7 @@ jobs:
           key: ${{ runner.os }}-composer-${{ hashFiles('**/composer.lock') }}
       - if: matrix.install-fixer-from-master-branch
         run: composer require friendsofphp/php-cs-fixer:dev-master --no-update
-      - run: composer update --no-progress ${{ matrix.composer_flags }}
+      - run: composer update --no-progress ${{ matrix.composer-flags }}
       - run: composer test -- --coverage-clover=./build/logs/clover.xml
       - if: matrix.coverage-driver == 'pcov'
         env:

.php-cs-fixer.php

@@ -32,7 +32,6 @@
 unset($rules['assign_null_coalescing_to_coalesce_equal']); // TODO: remove when dropping support to PHP <8.0
 unset($rules['get_class_to_class_keyword']); // TODO: remove when dropping support to PHP <8.0
 unset($rules['modernize_strpos']); // TODO: remove when dropping support to PHP <8.0
-unset($rules['use_arrow_functions']); // TODO: remove when dropping support to PHP <7.4
 unset($rules[PhpCsFixerCustomFixers\Fixer\PhpdocOnlyAllowedAnnotationsFixer::name()]); // TODO: remove after new php-cs-fixer-config release
 unset($rules[PhpCsFixerCustomFixers\Fixer\PromotedConstructorPropertyFixer::name()]); // TODO: remove when dropping support to PHP <8.0
 $rules['trailing_comma_in_multiline'] = true; // TODO: remove when dropping support to PHP <8.0

CHANGELOG.md

@@ -1,6 +1,7 @@
 # CHANGELOG for PHP CS Fixer: custom fixers
 
 ## v3.8.0
+- Update minimum PHP version to 7.4
 - DataProviderStaticFixer - add option "force"
 
 ## v3.7.0

composer.json

@@ -10,7 +10,7 @@
         }
     ],
     "require": {
-        "php": "^7.2 || ^8.0",
+        "php": "^7.4 || ^8.0",
         "ext-filter": "*",
         "ext-tokenizer": "*",
         "friendsofphp/php-cs-fixer": "^3.1.0",

src/Fixer/PhpUnitNoUselessReturnFixer.php

@@ -30,9 +30,7 @@ public function getDefinition(): FixerDefinitionInterface
             \sprintf(
                 'PHPUnit %s functions should not be followed directly by return.',
                 Utils::naturalLanguageJoinWithBackticks(\array_map(
-                    static function (array $token): string {
-                        return $token[1];
-                    },
+                    static fn (array $token): string => $token[1],
                     self::FUNCTION_TOKENS
                 ))
             ),

tests/AutoReview/SrcCodeTest.php

@@ -114,14 +114,10 @@ public function testThereIsNoPregFunctionUsedDirectly(string $className): void
 
         $stringTokens = \array_filter(
             $tokens,
-            static function (Token $token): bool {
-                return $token->isGivenKind(\T_STRING);
-            }
+            static fn (Token $token): bool => $token->isGivenKind(\T_STRING)
         );
         $strings = \array_map(
-            static function (Token $token): string {
-                return $token->getContent();
-            },
+            static fn (Token $token): string => $token->getContent(),
             $stringTokens
         );
         $strings = \array_unique($strings);

tests/AutoReview/TestsCodeTest.php

@@ -157,9 +157,7 @@ private function getDataProviders(string $className): array
     {
         return \array_filter(
             $this->getMethods($className, \ReflectionMethod::IS_PUBLIC),
-            static function (\ReflectionMethod $reflectionMethod): bool {
-                return \strpos($reflectionMethod->getName(), 'provide') === 0;
-            }
+            static fn (\ReflectionMethod $reflectionMethod): bool => \strpos($reflectionMethod->getName(), 'provide') === 0
         );
     }
 
@@ -172,9 +170,7 @@ private function getMethods(string $className, ?int $methodFilter = null): array
 
         return \array_filter(
             $reflectionClass->getMethods($methodFilter),
-            static function (\ReflectionMethod $reflectionMethod) use ($reflectionClass): bool {
-                return $reflectionMethod->getFileName() === $reflectionClass->getFileName();
-            }
+            static fn (\ReflectionMethod $reflectionMethod): bool => $reflectionMethod->getFileName() === $reflectionClass->getFileName()
         );
     }
 

tests/FixersTest.php

@@ -68,9 +68,7 @@ public static function provideFixerIsInCollectionCases(): iterable
     private function fixerNamesFromCollection(): array
     {
         return \array_map(
-            static function (FixerInterface $fixer): string {
-                return $fixer->getName();
-            },
+            static fn (FixerInterface $fixer): string => $fixer->getName(),
             \iterator_to_array(new Fixers())
         );
     }