ReadonlyPromotedPropertiesFixer - support asymmetric visibility

Author: kubawerlos

CHANGELOG.md

@@ -1,5 +1,8 @@
 # CHANGELOG for PHP CS Fixer: custom fixers
 
+## v3.25.0
+- ReadonlyPromotedPropertiesFixer - support asymmetric visibility
+
 ## v3.24.0
 - Add PhpUnitRequiresConstraintFixer
 

README.md

@@ -5,7 +5,7 @@
 [![Latest stable version](https://img.shields.io/packagist/v/kubawerlos/php-cs-fixer-custom-fixers.svg?label=current%20version)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 [![PHP version](https://img.shields.io/packagist/php-v/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://php.net)
 [![License](https://img.shields.io/github/license/kubawerlos/php-cs-fixer-custom-fixers.svg)](LICENSE)
-![Tests](https://img.shields.io/badge/tests-3610-brightgreen.svg)
+![Tests](https://img.shields.io/badge/tests-3614-brightgreen.svg)
 [![Downloads](https://img.shields.io/packagist/dt/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 
 [![CI status](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions/workflows/ci.yaml/badge.svg)](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions/workflows/ci.yaml)

tests/Fixer/AbstractFixerTestCase.php

@@ -40,6 +40,7 @@ abstract class AbstractFixerTestCase extends TestCase
         'testFix80',
         'testFix81',
         'testFix82',
+        'testFix84',
         'testIsRisky',
         'testReversingCodeSample',
         'testStringIsTheSame',

tests/Fixer/ReadonlyPromotedPropertiesFixerTest.php

@@ -173,4 +173,88 @@ class Baz { public function __construct(public int $x) {} }
             ',
         ];
     }
+
+    /**
+     * @dataProvider provideFix84Cases
+     *
+     * @requires PHP >= 8.4
+     */
+    public function testFix84(string $expected, ?string $input = null): void
+    {
+        $this->doTest($expected, $input);
+    }
+
+    /**
+     * @return iterable<string, array{0: string, 1?: string}>
+     */
+    public static function provideFix84Cases(): iterable
+    {
+        yield 'asymmetric visibility with both visibilities' => [
+            <<<'PHP'
+            <?php
+            final class Foo {
+                public function __construct(
+                    public public(set) readonly int $a,
+                    public protected(set) readonly int $b,
+                    public private(set) readonly int $c,
+                    protected protected(set) readonly int $d,
+                    protected private(set) readonly int $e,
+                    private private(set) readonly int $f,
+                ) {}
+            }
+            PHP,
+            <<<'PHP'
+            <?php
+            final class Foo {
+                public function __construct(
+                    public public(set) int $a,
+                    public protected(set) int $b,
+                    public private(set) int $c,
+                    protected protected(set) int $d,
+                    protected private(set) int $e,
+                    private private(set) int $f,
+                ) {}
+            }
+            PHP,
+        ];
+
+        yield 'asymmetric visibility with only write visibility' => [
+            <<<'PHP'
+            <?php
+            final class Foo {
+                public function __construct(
+                    public(set) readonly int $a,
+                    protected(set) readonly int $b,
+                    private(set) readonly int $c,
+                ) {}
+            }
+            PHP,
+            <<<'PHP'
+            <?php
+            final class Foo {
+                public function __construct(
+                    public(set) int $a,
+                    protected(set) int $b,
+                    private(set) int $c,
+                ) {}
+            }
+            PHP,
+        ];
+
+        yield 'readonly asymmetric visibility' => [
+            <<<'PHP'
+            <?php
+            final class Foo {
+                public function __construct(
+                    readonly public public(set) int $a,
+                    public readonly protected(set) int $b,
+                    public private(set) readonly int $c,
+                    readonly private(set) int $e,
+                    private(set) readonly int $f,
+                ) {}
+            }
+            PHP,
+        ];
+
+    }
 }