Skip to content

Commit 7cd8751

Browse files
committed
Make fixer risky
1 parent 965d4be commit 7cd8751

File tree

3 files changed

+5
-7
lines changed

3 files changed

+5
-7
lines changed

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ Empty function body must be abbreviated as `{}` and placed on the same line as t
168168

169169
#### ForeachUseValueFixer
170170
Value from `foreach` must not be used if possible.
171+
*Risky: when the value is re-used or being sorted.*
171172
```diff
172173
<?php
173174
foreach ($elements as $key => $value) {

src/Fixer/ForeachUseValueFixer.php

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,7 @@ public function getDefinition(): FixerDefinitionInterface
5757
PHP,
5858
)],
5959
'',
60+
'when the value is re-used or being sorted',
6061
);
6162
}
6263

@@ -72,7 +73,7 @@ public function isCandidate(Tokens $tokens): bool
7273

7374
public function isRisky(): bool
7475
{
75-
return false;
76+
return true;
7677
}
7778

7879
public function fix(\SplFileInfo $file, Tokens $tokens): void
@@ -155,11 +156,7 @@ private function fixForeachBody(
155156
string $variableName
156157
): void {
157158
$sequence = [
158-
$arrayToken,
159-
'[',
160-
[\T_VARIABLE, $keyName],
161-
']',
162-
];
159+
$arrayToken, '[', [\T_VARIABLE, $keyName], ']'];
163160

164161
$index = $openBraceIndex;
165162
while (($found = $tokens->findSequence($sequence, $index, $closeBraceIndex)) !== null) {

tests/Fixer/ForeachUseValueFixerTest.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -20,7 +20,7 @@ final class ForeachUseValueFixerTest extends AbstractFixerTestCase
2020
{
2121
public function testIsRisky(): void
2222
{
23-
self::assertRiskiness(false);
23+
self::assertRiskiness(true);
2424
}
2525

2626
/**

0 commit comments

Comments
 (0)