Make DataProviderStaticFixer always risky (#929)

kubawerlos · web-flow · commit a255c0e6ef0f · 2023-12-23T11:34:41.000Z
diff --git a/README.md b/README.md
@@ -5,7 +5,7 @@
 [![Latest stable version](https://img.shields.io/packagist/v/kubawerlos/php-cs-fixer-custom-fixers.svg?label=current%20version)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 [![PHP version](https://img.shields.io/packagist/php-v/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://php.net)
 [![License](https://img.shields.io/github/license/kubawerlos/php-cs-fixer-custom-fixers.svg)](LICENSE)
-![Tests](https://img.shields.io/badge/tests-3511-brightgreen.svg)
+![Tests](https://img.shields.io/badge/tests-3510-brightgreen.svg)
 [![Downloads](https://img.shields.io/packagist/dt/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 
 [![CI Status](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/workflows/CI/badge.svg?branch=main)](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions)
diff --git a/src/Fixer/DataProviderStaticFixer.php b/src/Fixer/DataProviderStaticFixer.php
@@ -90,7 +90,7 @@ public function isCandidate(Tokens $tokens): bool
 
     public function isRisky(): bool
     {
-        return $this->force;
+        return $this->phpUnitDataProviderStaticFixer->isRisky();
     }
 
     public function fix(\SplFileInfo $file, Tokens $tokens): void
diff --git a/tests/Fixer/AbstractFixerTestCase.php b/tests/Fixer/AbstractFixerTestCase.php
@@ -37,9 +37,7 @@ abstract class AbstractFixerTestCase extends TestCase
         'testFixPre80',
         'testFix80',
         'testFix82',
-        'testIsNotRiskyWithoutForceOption',
         'testIsRisky',
-        'testIsRiskyWithForceOption',
         'testReversingCodeSample',
         'testStringIsTheSame',
         'testSuccessorName',
diff --git a/tests/Fixer/DataProviderStaticFixerTest.php b/tests/Fixer/DataProviderStaticFixerTest.php
@@ -23,17 +23,11 @@
  */
 final class DataProviderStaticFixerTest extends AbstractFixerTestCase
 {
-    public function testIsRiskyWithForceOption(): void
+    public function testIsRisky(): void
     {
-        $this->fixer->configure(['force' => true]);
         self::assertTrue($this->fixer->isRisky());
     }
 
-    public function testIsNotRiskyWithoutForceOption(): void
-    {
-        self::assertFalse($this->fixer->isRisky());
-    }
-
     public function testSuccessorName(): void
     {
         self::assertContains('php_unit_data_provider_static', $this->fixer->getSuccessorsNames());

Original file line number	Diff line number	Diff line change
`@@ -90,7 +90,7 @@ public function isCandidate(Tokens $tokens): bool`
`90`	`90`
`91`	`91`	`public function isRisky(): bool`
`92`	`92`	`{`
`93`		`- return $this->force;`
	`93`	`+ return $this->phpUnitDataProviderStaticFixer->isRisky();`
`94`	`94`	`}`
`95`	`95`
`96`	`96`	`public function fix(\SplFileInfo $file, Tokens $tokens): void`
Original file line number	Diff line number	Diff line change
`@@ -23,17 +23,11 @@`
`23`	`23`	`*/`
`24`	`24`	`final class DataProviderStaticFixerTest extends AbstractFixerTestCase`
`25`	`25`	`{`
`26`		`- public function testIsRiskyWithForceOption(): void`
	`26`	`+ public function testIsRisky(): void`
`27`	`27`	`{`
`28`		`- $this->fixer->configure(['force' => true]);`
`29`	`28`	`self::assertTrue($this->fixer->isRisky());`
`30`	`29`	`}`
`31`	`30`
`32`		`- public function testIsNotRiskyWithoutForceOption(): void`
`33`		`- {`
`34`		`- self::assertFalse($this->fixer->isRisky());`
`35`		`- }`
`36`		`-`
`37`	`31`	`public function testSuccessorName(): void`
`38`	`32`	`{`
`39`	`33`	`self::assertContains('php_unit_data_provider_static', $this->fixer->getSuccessorsNames());`