PromotedConstructorPropertyFixer - do not crash on variable property (#733)

Author: kubawerlos

README.md

@@ -3,7 +3,7 @@
 [![Latest stable version](https://img.shields.io/packagist/v/kubawerlos/php-cs-fixer-custom-fixers.svg?label=current%20version)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 [![PHP version](https://img.shields.io/packagist/php-v/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://php.net)
 [![License](https://img.shields.io/github/license/kubawerlos/php-cs-fixer-custom-fixers.svg)](LICENSE)
-![Tests](https://img.shields.io/badge/tests-3364-brightgreen.svg)
+![Tests](https://img.shields.io/badge/tests-3366-brightgreen.svg)
 [![Downloads](https://img.shields.io/packagist/dt/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 
 [![CI Status](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/workflows/CI/badge.svg?branch=main)](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions)

src/Analyzer/Analysis/ConstructorAnalysis.php

@@ -136,6 +136,9 @@ private function getPropertyIndex(int $index, int $openBrace): ?int
         }
 
         $propertyIndex = $this->tokens->getPrevMeaningfulToken($assignmentIndex);
+        if (!$this->tokens[$propertyIndex]->isGivenKind(\T_STRING)) {
+            return null;
+        }
         \assert(\is_int($propertyIndex));
 
         $objectOperatorIndex = $this->tokens->getPrevMeaningfulToken($propertyIndex);

tests/Analyzer/Analysis/ConstructorAnalysisTest.php

@@ -149,5 +149,14 @@ public function __construct($x, $y, $z) {
                 }
             }',
         ];
+
+        yield 'variable property assignment' => [
+            [],
+            '<?php class Foo {
+                public function __construct($x) {
+                    $this->$x = $x;
+                }
+            }',
+        ];
     }
 }

tests/Fixer/PromotedConstructorPropertyFixerTest.php

@@ -131,6 +131,16 @@ public function __construct(string $x, string $y)
             }',
         ];
 
+        yield 'do not promote variable property' => [
+            '<?php class Foo {
+                private string $bar;
+                public function __construct(string $bar) {
+                    $this->$bar = $bar;
+                }
+            }
+            ',
+        ];
+
         yield 'var keywords are not promoted' => [
             '<?php class Foo {
                 public function __construct(public int $x) {