DataProviderStaticFixer - make risky based on config (#747)

Author: kubawerlos

.dev-tools/src/Readme/ReadmeCommand.php

@@ -20,6 +20,7 @@
 use PhpCsFixer\Tokenizer\Tokens;
 use PhpCsFixer\WhitespacesFixerConfig;
 use PhpCsFixerCustomFixers\Fixer\AbstractFixer;
+use PhpCsFixerCustomFixers\Fixer\DataProviderStaticFixer;
 use PhpCsFixerCustomFixers\Fixer\DeprecatingFixerInterface;
 use PhpCsFixerCustomFixers\Fixers;
 use SebastianBergmann\Diff\Differ;
@@ -186,12 +187,18 @@ private function fixers(): string
 
             $output .= $fixer instanceof DeprecatedFixerInterface ? \sprintf("\n  DEPRECATED: use `%s` instead.", \implode('`, `', $fixer->getSuccessorsNames())) : '';
 
+            if ($fixer instanceof DataProviderStaticFixer) {
+                $fixer->configure(['force' => true]);
+            }
             if ($fixer->isRisky()) {
                 $output .= \sprintf(
                     "\n  *Risky: %s.*",
                     $fixer->getDefinition()->getRiskyDescription()
                 );
             }
+            if ($fixer instanceof DataProviderStaticFixer) {
+                $fixer->configure(['force' => false]);
+            }
 
             if ($fixer instanceof ConfigurableFixerInterface) {
                 $output .= "\nConfiguration options:";

README.md

@@ -3,7 +3,7 @@
 [![Latest stable version](https://img.shields.io/packagist/v/kubawerlos/php-cs-fixer-custom-fixers.svg?label=current%20version)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 [![PHP version](https://img.shields.io/packagist/php-v/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://php.net)
 [![License](https://img.shields.io/github/license/kubawerlos/php-cs-fixer-custom-fixers.svg)](LICENSE)
-![Tests](https://img.shields.io/badge/tests-3374-brightgreen.svg)
+![Tests](https://img.shields.io/badge/tests-3375-brightgreen.svg)
 [![Downloads](https://img.shields.io/packagist/dt/kubawerlos/php-cs-fixer-custom-fixers.svg)](https://packagist.org/packages/kubawerlos/php-cs-fixer-custom-fixers)
 
 [![CI Status](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/workflows/CI/badge.svg?branch=main)](https://github.com/kubawerlos/php-cs-fixer-custom-fixers/actions)

src/Fixer/DataProviderStaticFixer.php

@@ -83,7 +83,7 @@ public function isCandidate(Tokens $tokens): bool
 
     public function isRisky(): bool
     {
-        return true;
+        return $this->force;
     }
 
     public function fix(\SplFileInfo $file, Tokens $tokens): void

tests/Fixer/DataProviderStaticFixerTest.php

@@ -18,11 +18,17 @@
  */
 final class DataProviderStaticFixerTest extends AbstractFixerTestCase
 {
-    public function testIsRisky(): void
+    public function testIsRiskyWithForceOption(): void
     {
+        $this->fixer->configure(['force' => true]);
         self::assertTrue($this->fixer->isRisky());
     }
 
+    public function testIsNotRiskyWithoutForceOption(): void
+    {
+        self::assertFalse($this->fixer->isRisky());
+    }
+
     public function testConfiguration(): void
     {
         $options = $this->fixer->getConfigurationDefinition()->getOptions();