fix multiple interfaces address

Author: kubealex

README.md

@@ -113,14 +113,16 @@ module "instance_provisioning" {
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:12:34:56"
-      interface_addresses       = ["192.168.1.2"]
+      interface_address         = "192.168.1.2"
+      interface_prefix          = 24
       interface_hostname        = "eth0-host"
       interface_wait_for_lease  = true
     },
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:65:78:9A"
-      interface_addresses       = ["192.168.2.2"]
+      interface_address         = "192.168.2.2"
+      interface_prefix          = 16
       interface_hostname        = "eth1-host"
       interface_wait_for_lease  = false
     },

examples/terraform-libvirt-instance/main.tf

@@ -17,7 +17,6 @@ module "instance_provisioning" {
     sshkey                     = "ssh-rsa AAAAB3NzaC1yc2EAAA...your-ssh-key-here"
   }
 
-  instance_libvirt_network     = "default"
   instance_libvirt_pool        = "default"
   instance_uefi_enabled        = true
   instance_firmware            = "/usr/share/edk2/ovmf/OVMF_CODE.fd"
@@ -26,14 +25,16 @@ module "instance_provisioning" {
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:12:34:56"
-      interface_addresses       = ["192.168.1.2"]
+      interface_address         = "192.168.1.2"
+      interface_prefix          = 24
       interface_hostname        = "eth0-host"
       interface_wait_for_lease  = true
     },
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:65:78:9A"
-      interface_addresses       = ["192.168.2.2"]
+      interface_address         = "192.168.2.2"
+      interface_prefix          = 16
       interface_hostname        = "eth1-host"
       interface_wait_for_lease  = false
     },

modules/terraform-libvirt-instance/README.md

@@ -39,7 +39,8 @@ This Terraform module provisions virtual instances with customizable configurati
 | ---------------------------- | -------------------------------------------------- | -------- | ------------- |
 | `interface_network`             | Name of the network to attach the interface to                      | ✔️       |               |
 | `interface_mac_address`     | MAC address of the network interface               | ❌       |               |
-| `interface_addresses`       | List of IP addresses for the network interface    | ❌       | `[]` (empty list) |
+| `interface_address`       | List of IP addresses for the network interface    | ❌       | `` (empty list) |
+| `interface_prefix`        | Prefix of the interface address for the network interface                | ❌       |       24        |
 | `interface_hostname`        | Hostname for the network interface                | ❌       |               |
 | `interface_wait_for_lease`  | Whether to wait for DHCP lease on the interface   | ❌       | `false`       |
 
@@ -74,14 +75,16 @@ module "instance_provisioning" {
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:12:34:56"
-      interface_addresses       = ["192.168.1.2"]
+      interface_address         = "192.168.1.2"
+      interface_prefix          = 24
       interface_hostname        = "eth0-host"
       interface_wait_for_lease  = true
     },
     {
       interface_network_name    = "default"
       interface_mac_address     = "52:54:00:65:78:9A"
-      interface_addresses       = ["192.168.2.2"]
+      interface_address         = "192.168.2.2"
+      interface_prefix          = 16
       interface_hostname        = "eth1-host"
       interface_wait_for_lease  = false
     },

modules/terraform-libvirt-instance/main.tf

@@ -139,6 +139,12 @@ resource "libvirt_domain" "libvirt-vm" {
       source = { network = { network = iface.interface_network } }
       model  = { type = "virtio" }
       mac    = iface.interface_mac_address != null ? { address = iface.interface_mac_address } : null
+
+      # Only configure static IP if user specified one, otherwise use DHCP
+      ip = iface.interface_address != null ? [{
+        address = iface.interface_address
+        prefix  = iface.interface_prefix
+      }] : null
     }]
 
     graphics = [

modules/terraform-libvirt-instance/variables.tf

@@ -109,16 +109,13 @@ variable "instance_firmware" {
 
 variable "instance_network_interfaces" {
   type = list(object({
-    interface_network       = string
-    interface_mac_address   = optional(string)
-    # Note: The following attributes are not directly supported in v0.9+ devices.interfaces
-    # They would need to be configured via network DHCP or handled differently
-    interface_addresses     = optional(list(string), [])
-    interface_hostname      = optional(string)
-    interface_wait_for_lease = optional(bool, true)
+    interface_network     = string
+    interface_mac_address = optional(string)
+    interface_address     = optional(string)
+    interface_prefix      = optional(number, 24)
   }))
   default = [{
     interface_network = "default"
   }]
-  description = "A list of network interfaces to add to the instance"
+  description = "A list of network interfaces to add to the instance. Uses DHCP by default, or specify interface_address for static IP assignment. interface_prefix defaults to 24."
 }